Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: ios/chrome/browser/web/BUILD.gn

Issue 2807843002: Refactor creation of SadTabView into a tab helper object (Closed)
Patch Set: Attempt to fix build dependency Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//ios/web/js_compile.gni") 5 import("//ios/web/js_compile.gni")
6 6
7 source_set("web") { 7 source_set("web") {
8 configs += [ "//build/config/compiler:enable_arc" ] 8 configs += [ "//build/config/compiler:enable_arc" ]
9 sources = [ 9 sources = [
10 "dom_altering_lock.h", 10 "dom_altering_lock.h",
11 "dom_altering_lock.mm", 11 "dom_altering_lock.mm",
12 "navigation_manager_util.h", 12 "navigation_manager_util.h",
13 "navigation_manager_util.mm", 13 "navigation_manager_util.mm",
14 "network_activity_indicator_tab_helper.h", 14 "network_activity_indicator_tab_helper.h",
15 "network_activity_indicator_tab_helper.mm", 15 "network_activity_indicator_tab_helper.mm",
16 "repost_form_tab_helper.h", 16 "repost_form_tab_helper.h",
17 "repost_form_tab_helper.mm", 17 "repost_form_tab_helper.mm",
18 "sad_tab_tab_helper.h",
19 "sad_tab_tab_helper.mm",
18 ] 20 ]
19 deps = [ 21 deps = [
22 ":sad_tab_tab_helper_delegate",
20 "//base", 23 "//base",
21 "//components/strings", 24 "//components/strings",
22 "//ios/chrome/browser/ui", 25 "//ios/chrome/browser/ui",
23 "//ios/chrome/browser/ui/alert_coordinator:alert_coordinator", 26 "//ios/chrome/browser/ui/alert_coordinator:alert_coordinator",
27 "//ios/chrome/browser/ui/sad_tab:sad_tab",
24 "//ios/chrome/browser/ui/util:util", 28 "//ios/chrome/browser/ui/util:util",
25 "//ios/web", 29 "//ios/web",
26 "//ios/web:web_arc", 30 "//ios/web:web_arc",
27 "//ui/base", 31 "//ui/base",
28 ] 32 ]
29 } 33 }
30 34
35 source_set("sad_tab_tab_helper_delegate") {
36 configs += [ "//build/config/compiler:enable_arc" ]
37 sources = [
38 "sad_tab_tab_helper_delegate.h",
39 ]
40 }
41
31 source_set("unit_tests") { 42 source_set("unit_tests") {
32 configs += [ "//build/config/compiler:enable_arc" ] 43 configs += [ "//build/config/compiler:enable_arc" ]
33 testonly = true 44 testonly = true
34 sources = [ 45 sources = [
35 "navigation_manager_util_unittest.mm", 46 "navigation_manager_util_unittest.mm",
36 "network_activity_indicator_tab_helper_unittest.mm", 47 "network_activity_indicator_tab_helper_unittest.mm",
37 "repost_form_tab_helper_unittest.mm", 48 "repost_form_tab_helper_unittest.mm",
49 "sad_tab_tab_helper_unittest.mm",
38 ] 50 ]
39 deps = [ 51 deps = [
52 ":sad_tab_tab_helper_delegate",
40 ":web", 53 ":web",
41 "//base:base", 54 "//base:base",
42 "//base/test:test_support", 55 "//base/test:test_support",
43 "//components/strings:components_strings_grit", 56 "//components/strings:components_strings_grit",
44 "//ios/chrome/browser/ui:ui", 57 "//ios/chrome/browser/ui:ui",
45 "//ios/chrome/test:test_support", 58 "//ios/chrome/test:test_support",
46 "//ios/web:test_support", 59 "//ios/web:test_support",
47 "//ios/web:web_arc", 60 "//ios/web:web_arc",
48 "//testing/gtest", 61 "//testing/gtest",
49 "//ui/base:base", 62 "//ui/base:base",
(...skipping 256 matching lines...) Expand 10 before | Expand all | Expand 10 after
306 "early_page_script_perftest.mm", 319 "early_page_script_perftest.mm",
307 ] 320 ]
308 deps = [ 321 deps = [
309 "//base", 322 "//base",
310 "//ios/chrome/test/base:perf_test_support", 323 "//ios/chrome/test/base:perf_test_support",
311 "//ios/web", 324 "//ios/web",
312 "//ios/web:test_support", 325 "//ios/web:test_support",
313 ] 326 ]
314 libs = [ "WebKit.framework" ] 327 libs = [ "WebKit.framework" ]
315 } 328 }
OLDNEW
« no previous file with comments | « ios/chrome/browser/ui/sad_tab/sad_tab_view.mm ('k') | ios/chrome/browser/web/sad_tab_tab_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698