[Devtools] Updated format to store product registry data

[Devtools] Updated format to store product registry data

Prepares the UI and product registry file format to add visual markers of
network resource classifications.

R=pfeldman
BUG=664704
Review-Url: https://codereview.chromium.org/2807823002
Cr-Commit-Position: refs/heads/master@{#464610}
Committed: https://chromium.googlesource.com/chromium/src/+/7dba9902a5c91c8474782336892c961fd94f82be

[allada, 2017-04-07 22:33:26]

Patchset #1 (id:1) has been deleted

[allada, 2017-04-07 22:46:38]

Patchset #1 (id:20001) has been deleted

[allada, 2017-04-07 22:58:49]

PTL

[pfeldman, 2017-04-07 23:22:01]

https://codereview.chromium.org/2807823002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2807823002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:83:
extension.instance().then(instance => this._rowDecorators.add(instance));
You should barrier those and re-decorate everything once they load (imagine it
takes 20 seconds to fetch your remote module).

https://codereview.chromium.org/2807823002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/networkLogView.css
(right):

https://codereview.chromium.org/2807823002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/networkLogView.css:68:
.network-log-grid .product-type .product-extension-column::before {
Which product? :) You've abstracted from the products!

https://codereview.chromium.org/2807823002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network_group_lookup/NetworkProductGroupLookup.js
(right):

https://codereview.chromium.org/2807823002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network_group_lookup/NetworkProductGroupLookup.js:132:
element.classList.add('product-type-' + typeName);
You need to inject your stylesheet if you want it right.

[allada, 2017-04-10 22:00:45]

Patchset #2 (id:60001) has been deleted

[allada, 2017-04-10 22:18:45]

Patchset #2 (id:80001) has been deleted

[allada, 2017-04-10 22:20:45]

PTaL

https://codereview.chromium.org/2807823002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2807823002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:83:
extension.instance().then(instance => this._rowDecorators.add(instance));
On 2017/04/07 23:22:01, pfeldman wrote:
> You should barrier those and re-decorate everything once they load (imagine it
> takes 20 seconds to fetch your remote module).

Done.

https://codereview.chromium.org/2807823002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/networkLogView.css
(right):

https://codereview.chromium.org/2807823002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/networkLogView.css:68:
.network-log-grid .product-type .product-extension-column::before {
On 2017/04/07 23:22:01, pfeldman wrote:
> Which product? :) You've abstracted from the products!

I'm not sure what you mean, but product-type only gets added if it finds a
classification.

https://codereview.chromium.org/2807823002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network_group_lookup/NetworkProductGroupLookup.js
(right):

https://codereview.chromium.org/2807823002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network_group_lookup/NetworkProductGroupLookup.js:132:
element.classList.add('product-type-' + typeName);
On 2017/04/07 23:22:01, pfeldman wrote:
> You need to inject your stylesheet if you want it right.

Done.

[pfeldman, 2017-04-11 00:07:31]

https://codereview.chromium.org/2807823002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2807823002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:506:
this._invalidateAllItems(true);
I was suggesting to put a barrier to coalesce those updates.

https://codereview.chromium.org/2807823002/diff/100001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/devtools/front_end/network_group_lookup/NetworkProductGroupLookup.js
(right):

https://codereview.chromium.org/2807823002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/network_group_lookup/NetworkProductGroupLookup.js:125:
UI.appendStyle(dataGrid.element,
'network_group_lookup/networkProductTypeGroupLookup.css');
Let's expose registerRequiredCSS on DataGrid as we do in other places that
inject css. That way we can track them as we migrate to components.

https://codereview.chromium.org/2807823002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/network_group_lookup/NetworkProductGroupLookup.js:140:
element.classList.add('product-type-' + typeName);
Better yet, set your style via CSSOM (yes, I mean that it is still better).

[pfeldman, 2017-04-11 00:07:42]

lgtm if you inline the style.

[allada, 2017-04-11 22:48:55]

Patchset #3 (id:120001) has been deleted

[allada, 2017-04-12 00:53:47]

pfeldman@, can you let me know if this is on the lines of what you were
suggesting?

https://codereview.chromium.org/2807823002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2807823002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:506:
this._invalidateAllItems(true);
On 2017/04/11 00:07:31, pfeldman wrote:
> I was suggesting to put a barrier to coalesce those updates.

Done.

[allada, 2017-04-12 01:30:42]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 01:31:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 02:51:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 02:51:41]

Dry run: This issue passed the CQ dry run.

[allada, 2017-04-13 21:09:19]

The CQ bit was checked by allada@chromium.org

[allada, 2017-04-13 21:09:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2807823002/#ps160001
(title: "changes")

[commit-bot: I haz the power, 2017-04-13 21:09:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 21:15:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 21:15:05]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[allada, 2017-04-13 22:19:40]

Patchset #5 (id:170001) has been deleted

[allada, 2017-04-13 22:20:55]

The CQ bit was checked by allada@chromium.org

[allada, 2017-04-13 22:20:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2807823002/#ps190001
(title: "canges")

[commit-bot: I haz the power, 2017-04-13 22:21:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[allada, 2017-04-13 23:12:58]

The CQ bit was unchecked by allada@chromium.org

[allada, 2017-04-13 23:12:58]

The CQ bit was checked by allada@chromium.org

[commit-bot: I haz the power, 2017-04-13 23:13:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 23:42:06]

CQ is committing da patch.

Bot data: {"patchset_id": 190001, "attempt_start_ts": 1492125178890190,
"parent_rev": "b6ca3d65b4a1d2653384a84a62f7dde590dbbe4f", "commit_rev":
"7dba9902a5c91c8474782336892c961fd94f82be"}

[commit-bot: I haz the power, 2017-04-13 23:43:07]

Description was changed from

==========
[Devtools] Updated format to store product registry data

Prepares the UI and product registry file format to add visual markers of
network resource classifications.

R=pfeldman
BUG=664704
==========

to

==========
[Devtools] Updated format to store product registry data

Prepares the UI and product registry file format to add visual markers of
network resource classifications.

R=pfeldman
BUG=664704

Review-Url: https://codereview.chromium.org/2807823002
Cr-Commit-Position: refs/heads/master@{#464610}
Committed:
https://chromium.googlesource.com/chromium/src/+/7dba9902a5c91c8474782336892c...
==========

[commit-bot: I haz the power, 2017-04-13 23:43:10]

Committed patchset #5 (id:190001) as
https://chromium.googlesource.com/chromium/src/+/7dba9902a5c91c8474782336892c...