Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2807813002: tools: Make mass-rename.py print progress as it works (Closed)

Created:
3 years, 8 months ago by James Cook
Modified:
3 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

tools: Make mass-rename.py print progress as it works It takes a couple seconds per file, so when you're renaming hundreds of files it can look broken. Format is: [1/234] Moving: my_file.cc BUG=none TEST=manual, run it after a git mv Review-Url: https://codereview.chromium.org/2807813002 Cr-Commit-Position: refs/heads/master@{#463035} Committed: https://chromium.googlesource.com/chromium/src/+/ffcdf35afebd887f573eb77d5ca5358bea5243f0

Patch Set 1 #

Total comments: 1

Patch Set 2 : enumerate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M tools/git/mass-rename.py View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
James Cook
Dirk, please take a look. I'm planning to move some files this weekend. :-)
3 years, 8 months ago (2017-04-07 21:58:29 UTC) #4
Dirk Pranke
lgtm https://codereview.chromium.org/2807813002/diff/1/tools/git/mass-rename.py File tools/git/mass-rename.py (right): https://codereview.chromium.org/2807813002/diff/1/tools/git/mass-rename.py#newcode33 tools/git/mass-rename.py:33: for line in lines: Nit: can use: for ...
3 years, 8 months ago (2017-04-07 22:06:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807813002/20001
3 years, 8 months ago (2017-04-07 22:49:42 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 23:07:48 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ffcdf35afebd887f573eb77d5ca5...

Powered by Google App Engine
This is Rietveld 408576698