Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Issue 2807753002: Add test for removing and adding ticking AnimationPlayer (Closed)

Created:
3 years, 8 months ago by bokan
Modified:
3 years, 8 months ago
Reviewers:
ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add test for removing and adding ticking AnimationPlayer This is a test for the urgent fix landed in crrev.com/2791513002. BUG=704410 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2807753002 Cr-Commit-Position: refs/heads/master@{#462985} Committed: https://chromium.googlesource.com/chromium/src/+/b9dcad92b7ad50e6025f3e326af8ccf1f3a07e5c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M cc/animation/element_animations_unittest.cc View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
bokan
Hey Ali, here's a test for the fix I landed last week.
3 years, 8 months ago (2017-04-07 19:49:34 UTC) #3
ajuma
lgtm, thanks for the test!
3 years, 8 months ago (2017-04-07 19:59:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807753002/1
3 years, 8 months ago (2017-04-07 20:09:12 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 20:27:48 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b9dcad92b7ad50e6025f3e326af8...

Powered by Google App Engine
This is Rietveld 408576698