chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc - Issue 2807723002: Use SameDocument term instead of SamePage in chrome tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

Issue 2807723002: Use SameDocument term instead of SamePage in chrome tests. (Closed)

Patch Set: Self review Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/net/errorpage_browsertest.cc ('k') | chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

index a3ff77b3499f25db36673fe1d1ea446a5e10388c..2755d52d9ae40fd001e82752f141bff8a8df9887 100644

--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

@@ -30,7 +30,7 @@ namespace page_load_metrics {

namespace {

const char kDefaultTestUrl[] = "https://google.com/";

-const char kDefaultTestUrlAnchor[] = "https://google.com/#samepage";

+const char kDefaultTestUrlAnchor[] = "https://google.com/#samedocument";

const char kDefaultTestUrl2[] = "https://whatever.com/";

const char kFilteredStartUrl[] = "https://whatever.com/ignore-on-start";

const char kFilteredCommitUrl[] = "https://whatever.com/ignore-on-commit";

@@ -284,7 +284,7 @@ TEST_F(MetricsWebContentsObserverTest, NotInMainFrame) {

CheckTotalErrorEvents();

}

-TEST_F(MetricsWebContentsObserverTest, SamePageNoTrigger) {

+TEST_F(MetricsWebContentsObserverTest, SameDocumentNoTrigger) {

PageLoadTiming timing;

timing.navigation_start = base::Time::FromDoubleT(1);