Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2298)

Unified Diff: chrome/browser/net/errorpage_browsertest.cc

Issue 2807723002: Use SameDocument term instead of SamePage in chrome tests. (Closed)
Patch Set: Self review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/errorpage_browsertest.cc
diff --git a/chrome/browser/net/errorpage_browsertest.cc b/chrome/browser/net/errorpage_browsertest.cc
index 8bff12d910722439dd8d34cf5166fc1959893637..c05198ab548f9adaa7caaef343759ff7b78d01b3 100644
--- a/chrome/browser/net/errorpage_browsertest.cc
+++ b/chrome/browser/net/errorpage_browsertest.cc
@@ -735,11 +735,11 @@ IN_PROC_BROWSER_TEST_F(ErrorPageTest, DNSError_DoReload) {
EXPECT_EQ(3, link_doctor_interceptor()->num_requests());
}
-// Test that the reload button on a DNS error page works after a same page
+// Test that the reload button on a DNS error page works after a same document
// navigation on the error page. Error pages don't seem to do this, but some
// traces indicate this may actually happen. This test may hang on regression.
IN_PROC_BROWSER_TEST_F(ErrorPageTest,
- DNSError_DoReloadAfterSamePageNavigation) {
+ DNSError_DoReloadAfterSameDocumentNavigation) {
// The first navigation should fail, and the second one should be the error
// page.
ui_test_utils::NavigateToURLBlockUntilNavigationsComplete(
@@ -1132,10 +1132,10 @@ IN_PROC_BROWSER_TEST_F(ErrorPageAutoReloadTest, ManualReloadNotSuppressed) {
IDS_ERRORPAGES_SUGGESTION_CHECK_CONNECTION_HEADER)));
}
-// Make sure that a same page navigation does not cause issues with the
+// Make sure that a same document navigation does not cause issues with the
// auto-reload timer. Note that this test was added due to this case causing
// a crash. On regression, this test may hang due to a crashed renderer.
-IN_PROC_BROWSER_TEST_F(ErrorPageAutoReloadTest, IgnoresSamePageNavigation) {
+IN_PROC_BROWSER_TEST_F(ErrorPageAutoReloadTest, IgnoresSameDocumentNavigation) {
GURL test_url("http://error.page.auto.reload");
InstallInterceptor(test_url, 2);

Powered by Google App Engine
This is Rietveld 408576698