Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc

Issue 2807723002: Use SameDocument term instead of SamePage in chrome tests. (Closed)
Patch Set: Self review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/net/errorpage_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc
diff --git a/chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc b/chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc
index 950da1cb99f4bfeb16c2bb6df8a4d481478e708c..7f97d15f115362267b22a11fe9b614dec5c8e899 100644
--- a/chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc
+++ b/chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc
@@ -849,9 +849,9 @@ TEST_F(RecentTabHelperTest, OverlappingDownloadRequestsAreIgnored) {
EXPECT_EQ(offline_id_3, second_page->offline_id);
}
-// Simulates a same page navigation and checks we snapshot correctly with last_n
-// and downloads.
-TEST_F(RecentTabHelperTest, SaveSamePageNavigationSnapshots) {
+// Simulates a same document navigation and checks we snapshot correctly with
+// last_n and downloads.
+TEST_F(RecentTabHelperTest, SaveSameDocumentNavigationSnapshots) {
// Navigates and load fully then hide the tab so that a snapshot is created.
NavigateAndCommit(kTestPageUrl);
recent_tab_helper()->DocumentOnLoadCompletedInMainFrame();
@@ -864,14 +864,14 @@ TEST_F(RecentTabHelperTest, SaveSamePageNavigationSnapshots) {
// Now navigates same page and check the results of hiding the tab again.
// Another snapshot should be created to the updated URL.
- const GURL kTestPageUrlWithSegment(kTestPageUrl.spec() + "#aaa");
- NavigateAndCommit(kTestPageUrlWithSegment);
+ const GURL kTestPageUrlWithFragment(kTestPageUrl.spec() + "#aaa");
+ NavigateAndCommit(kTestPageUrlWithFragment);
recent_tab_helper()->WasHidden();
RunUntilIdle();
EXPECT_EQ(2U, page_added_count());
EXPECT_EQ(1U, model_removed_count());
ASSERT_EQ(1U, GetAllPages().size());
- EXPECT_EQ(kTestPageUrlWithSegment, GetAllPages()[0].url);
+ EXPECT_EQ(kTestPageUrlWithFragment, GetAllPages()[0].url);
// Now create a download request and check the snapshot is properly created.
const ClientId client_id = NewDownloadClientId();
@@ -882,7 +882,7 @@ TEST_F(RecentTabHelperTest, SaveSamePageNavigationSnapshots) {
EXPECT_EQ(1U, model_removed_count());
ASSERT_EQ(2U, GetAllPages().size());
const OfflinePageItem* downloads_page = FindPageForOfflineId(offline_id);
- EXPECT_EQ(kTestPageUrlWithSegment, downloads_page->url);
+ EXPECT_EQ(kTestPageUrlWithFragment, downloads_page->url);
EXPECT_EQ(client_id, downloads_page->client_id);
EXPECT_EQ(offline_id, downloads_page->offline_id);
}
« no previous file with comments | « no previous file | chrome/browser/net/errorpage_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698