📺 Move fullscreen web content to a new Activity.

chrome/android/java/src/org/chromium/chrome/browser/media/FullscreenMediaActivity.java

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.media;
+
+import org.chromium.chrome.R;
+import org.chromium.chrome.browser.IntentHandler;
+import org.chromium.chrome.browser.fullscreen.ChromeFullscreenManager;
+import org.chromium.chrome.browser.tab.Tab;
+import org.chromium.chrome.browser.tabmodel.AsyncTabParamsManager;
+import org.chromium.chrome.browser.tabmodel.TabReparentingParams;
+import org.chromium.chrome.browser.util.IntentUtils;
+import org.chromium.chrome.browser.webapps.FullScreenActivity;
+
+/**
+ * An Activity used to display fullscreen web contents.

[Bernhard Bauer, 2017/04/07 20:08:59]

…that is playing media? Or if we want this to be a generic activity for any
fullscreen WebContents, we should find a name that is less media-specific.

(Also, I would probably use `WebContents` here as a singular term, because there
is a single object.)

[mlamouri (slow - plz ping), 2017/04/10 12:56:21]

We don't know if an activity is playing media while fullscreen until it is
fullscreen so we will need to do this all the time.

[PEConn, 2017/04/11 00:54:46]

Renamed to FullscreenWebContentsActivity - I would've preferred
FullscreenActivity, but it (or more rather FullScreenActivity) was already
taken.

+ */
+public class FullscreenMediaActivity extends FullScreenActivity {
+    private Tab mTab;
+
+    @Override
+    protected Tab createTab() {
+        assert getIntent().hasExtra(IntentHandler.EXTRA_TAB_ID);
+
+        int tabId = IntentUtils.safeGetIntExtra(
+                getIntent(), IntentHandler.EXTRA_TAB_ID, Tab.INVALID_TAB_ID);
+        TabReparentingParams params = (TabReparentingParams) AsyncTabParamsManager.remove(tabId);
+
+        mTab = params.getTabToReparent();
+        mTab.attachAndFinishReparenting(this, createTabDelegateFactory(), params);

[Yusuf, 2017/04/10 17:08:49]

I don't think we need to cache this here since it gets added to the model.

[PEConn, 2017/04/11 00:54:46]

Oh yes sorry - I think this was cruft from an earlier version. I'm annoyed I
missed this because I got caught up on a bug because FullScreenActivity was
doing the same thing (caching the Tab instead of just getting it from the
TabModel).

+        return mTab;
+    }
+
+    @Override
+    protected int getControlContainerLayoutId() {
+        // TODO(peconn): Determine if there's something more suitable to use here.
+        return R.layout.webapp_control_container;
+    }
+
+    @Override
+    protected ChromeFullscreenManager createFullscreenManager() {
+        // Create a Fullscreen manager that won't change the Tab's fullscreen state when the
+        // Activity ends - we handle leaving fullscreen ourselves.
+        return new ChromeFullscreenManager(this, false, false);
+    }
+}