Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: content/browser/renderer_host/delegated_frame_host.cc

Issue 2807653003: Move Work From CompositorFrameSinkSupport() To Init() (Closed)
Patch Set: Set needs_sync_points Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/delegated_frame_host.cc
diff --git a/content/browser/renderer_host/delegated_frame_host.cc b/content/browser/renderer_host/delegated_frame_host.cc
index a4dbbc734ee2a9a444abf7ec9aefe4a19f99d85d..41f27e0292a361dbf0408e125ea7b0b8f5b26e29 100644
--- a/content/browser/renderer_host/delegated_frame_host.cc
+++ b/content/browser/renderer_host/delegated_frame_host.cc
@@ -833,12 +833,14 @@ void DelegatedFrameHost::UnlockResources() {
void DelegatedFrameHost::CreateCompositorFrameSinkSupport() {
DCHECK(!support_);
+ constexpr bool is_root = false;
+ constexpr bool handles_frame_sink_id_invalidation = false;
+ constexpr bool needs_sync_points = true;
ImageTransportFactory* factory = ImageTransportFactory::GetInstance();
support_ = base::MakeUnique<cc::CompositorFrameSinkSupport>(
- this, factory->GetContextFactoryPrivate()->GetSurfaceManager(),
- frame_sink_id_, false /* is_root */,
- false /* handles_frame_sink_id_invalidation */,
- true /* needs_sync_points */);
+ this, frame_sink_id_, is_root, handles_frame_sink_id_invalidation);
+ support_->Init(factory->GetContextFactoryPrivate()->GetSurfaceManager(),
+ needs_sync_points);
if (compositor_)
compositor_->AddFrameSink(frame_sink_id_);
if (needs_begin_frame_)

Powered by Google App Engine
This is Rietveld 408576698