Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame.cc

Issue 2807653003: Move Work From CompositorFrameSinkSupport() To Init() (Closed)
Patch Set: Set needs_sync_points Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_widget_host_view_child_frame.cc
diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.cc b/content/browser/frame_host/render_widget_host_view_child_frame.cc
index cc31069f5296c1f1b0f9f9e86b8083b2387bc016..96c78f1da71d29eabd3612f6f0d695ee0ac83604 100644
--- a/content/browser/frame_host/render_widget_host_view_child_frame.cc
+++ b/content/browser/frame_host/render_widget_host_view_child_frame.cc
@@ -689,10 +689,12 @@ cc::SurfaceId RenderWidgetHostViewChildFrame::SurfaceIdForTesting() const {
void RenderWidgetHostViewChildFrame::CreateCompositorFrameSinkSupport() {
DCHECK(!support_);
+ constexpr bool is_root = false;
+ constexpr bool handles_frame_sink_id_invalidation = false;
+ constexpr bool needs_sync_points = true;
support_ = base::MakeUnique<cc::CompositorFrameSinkSupport>(
- this, GetSurfaceManager(), frame_sink_id_, false /* is_root */,
- false /* handles_frame_sink_id_invalidation */,
- true /* needs_sync_points */);
+ this, frame_sink_id_, is_root, handles_frame_sink_id_invalidation);
+ support_->Init(GetSurfaceManager(), needs_sync_points);
if (parent_frame_sink_id_.is_valid()) {
GetSurfaceManager()->RegisterFrameSinkHierarchy(parent_frame_sink_id_,
frame_sink_id_);

Powered by Google App Engine
This is Rietveld 408576698