Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3072)

Unified Diff: chrome/android/java/res_template/xml/launchershortcuts.xml

Issue 2807613002: Add a disabled message for the static incognito launcher shortcut (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res_template/xml/launchershortcuts.xml
diff --git a/chrome/android/java/res_template/xml/launchershortcuts.xml b/chrome/android/java/res_template/xml/launchershortcuts.xml
index 5e6ebfbb5e4f36f1668c41d1012d0d518283e82c..bd6cd4af0f9725283d828ee81741b6f3925ba2b9 100644
--- a/chrome/android/java/res_template/xml/launchershortcuts.xml
+++ b/chrome/android/java/res_template/xml/launchershortcuts.xml
@@ -15,16 +15,13 @@
</intent>
</shortcut>
- <!-- The "New incognito tab" shortcut is now provided as a dynamic shortcut.
- See crbug.com/707446.
- TODO(twellington): Either remove this XML shorcut or add a disabled
- message. -->
<shortcut
android:shortcutId="new-incognito-tab-shortcut"
android:enabled="false"
android:icon="@drawable/shortcut_incognito"
android:shortcutShortLabel="@string/accessibility_tabstrip_incognito_identifier"
- android:shortcutLongLabel="@string/menu_new_incognito_tab" >
+ android:shortcutLongLabel="@string/menu_new_incognito_tab"
+ android:shortcutDisabledMessage="@string/disabled_incognito_launcher_shortcut_message" >
<intent
android:action="chromium.shortcut.action.OPEN_NEW_INCOGNITO_TAB"
android:targetPackage="{{manifest_package}}"
« no previous file with comments | « no previous file | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698