Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: chrome/android/java/res_template/xml/launchershortcuts.xml

Issue 2807613002: Add a disabled message for the static incognito launcher shortcut (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2016 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <shortcuts xmlns:android="http://schemas.android.com/apk/res/android" > 6 <shortcuts xmlns:android="http://schemas.android.com/apk/res/android" >
7 <shortcut 7 <shortcut
8 android:shortcutId="new-tab-shortcut" 8 android:shortcutId="new-tab-shortcut"
9 android:icon="@drawable/shortcut_newtab" 9 android:icon="@drawable/shortcut_newtab"
10 android:shortcutShortLabel="@string/menu_new_tab" > 10 android:shortcutShortLabel="@string/menu_new_tab" >
11 <intent 11 <intent
12 android:action="chromium.shortcut.action.OPEN_NEW_TAB" 12 android:action="chromium.shortcut.action.OPEN_NEW_TAB"
13 android:targetPackage="{{manifest_package}}" 13 android:targetPackage="{{manifest_package}}"
14 android:targetClass="org.chromium.chrome.browser.LauncherShortcutAct ivity" > 14 android:targetClass="org.chromium.chrome.browser.LauncherShortcutAct ivity" >
15 </intent> 15 </intent>
16 </shortcut> 16 </shortcut>
17 17
18 <!-- The "New incognito tab" shortcut is now provided as a dynamic shortcut.
19 See crbug.com/707446.
20 TODO(twellington): Either remove this XML shorcut or add a disabled
21 message. -->
22 <shortcut 18 <shortcut
23 android:shortcutId="new-incognito-tab-shortcut" 19 android:shortcutId="new-incognito-tab-shortcut"
24 android:enabled="false" 20 android:enabled="false"
25 android:icon="@drawable/shortcut_incognito" 21 android:icon="@drawable/shortcut_incognito"
26 android:shortcutShortLabel="@string/accessibility_tabstrip_incognito_ide ntifier" 22 android:shortcutShortLabel="@string/accessibility_tabstrip_incognito_ide ntifier"
27 android:shortcutLongLabel="@string/menu_new_incognito_tab" > 23 android:shortcutLongLabel="@string/menu_new_incognito_tab"
24 android:shortcutDisabledMessage="@string/disabled_incognito_launcher_sho rtcut_message" >
28 <intent 25 <intent
29 android:action="chromium.shortcut.action.OPEN_NEW_INCOGNITO_TAB" 26 android:action="chromium.shortcut.action.OPEN_NEW_INCOGNITO_TAB"
30 android:targetPackage="{{manifest_package}}" 27 android:targetPackage="{{manifest_package}}"
31 android:targetClass="org.chromium.chrome.browser.LauncherShortcutAct ivity" > 28 android:targetClass="org.chromium.chrome.browser.LauncherShortcutAct ivity" >
32 </intent> 29 </intent>
33 </shortcut> 30 </shortcut>
34 </shortcuts> 31 </shortcuts>
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698