Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 2807583002: Add app startup parameters to start the app in qr and incognito search. (Closed)

Created:
3 years, 8 months ago by lody
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add app startup parameters to start the app in qr and incognito search. BUG=622743 Review-Url: https://codereview.chromium.org/2807583002 Cr-Commit-Position: refs/heads/master@{#463584} Committed: https://chromium.googlesource.com/chromium/src/+/61312491232439beddbbd347cf86bf95f99aedb2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M ios/chrome/app/chrome_app_startup_parameters.mm View 1 chunk +27 lines, -0 lines 0 comments Download
M ios/chrome/common/app_group/app_group_constants.h View 1 chunk +6 lines, -0 lines 0 comments Download
M ios/chrome/common/app_group/app_group_constants.mm View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
lody
Can you please review? Thanks. (This is for widget use, trying to split into multiple ...
3 years, 8 months ago (2017-04-07 13:37:52 UTC) #2
marq (ping after 24h)
lgtm
3 years, 8 months ago (2017-04-07 16:02:59 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2782823003 Patch 200001). Please resolve the dependency and ...
3 years, 8 months ago (2017-04-11 08:32:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807583002/1
3 years, 8 months ago (2017-04-11 09:05:33 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 09:23:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/61312491232439beddbbd347cf86...

Powered by Google App Engine
This is Rietveld 408576698