Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2807513002: (Cleanup) MD Settings: explicitly import util in people-page (Closed)

Created:
3 years, 8 months ago by scottchen
Modified:
3 years, 8 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

(Cleanup) MD Settings: explicitly import util in people-page Currently people-page uses listenOnce() from util.js, which it only got access to transitively from other deps and is fragile. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2807513002 Cr-Commit-Position: refs/heads/master@{#462702} Committed: https://chromium.googlesource.com/chromium/src/+/ad7bad1f7f86672599b59bc6d26a65ced7605107

Patch Set 1 #

Patch Set 2 : also add in compiled_resources #

Patch Set 3 : alphabetize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/resources/settings/people_page/compiled_resources2.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
scottchen
3 years, 8 months ago (2017-04-06 22:30:17 UTC) #5
dpapad
lgtm
3 years, 8 months ago (2017-04-06 22:39:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807513002/40001
3 years, 8 months ago (2017-04-06 22:40:35 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 00:18:40 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ad7bad1f7f86672599b59bc6d26a...

Powered by Google App Engine
This is Rietveld 408576698