Track STL containers in QuicStreamFactory::DumpMemoryStats

Track STL containers in QuicStreamFactory::DumpMemoryStats

This CL includes QuicStreamFactory's STL containers in 
DumpMemoryStats(). This should let us know if any of them
grows too big and causes problems.

BUG=704953
Review-Url: https://codereview.chromium.org/2807493002
Cr-Commit-Position: refs/heads/master@{#463821}
Committed: https://chromium.googlesource.com/chromium/src/+/48e4f10eb4784c4cf1bd09efde38a86457faece2

[xunjieli, 2017-04-06 21:26:16]

Patchset #1 (id:1) has been deleted

[xunjieli, 2017-04-06 21:27:26]

Description was changed from

==========
Track STL containers in QuicStreamFactory::DumpMemoryStats


BUG=704953
==========

to

==========
Track STL containers in QuicStreamFactory::DumpMemoryStats

This CL includes QuicStreamFactory's STL containers in 
DumpMemoryStats(). This should let us know if any of them
grows too big and causes problems.

BUG=704953
==========

[xunjieli, 2017-04-06 21:27:26]

xunjieli@chromium.org changed reviewers:
+ ssid@chromium.org, zhongyi@chromium.org

[xunjieli, 2017-04-06 21:29:01]

Cherie and Sid: PTAL.

Sid, this shouldn't impact the OnMemoryDump() performance. Let me know if you'd
like me to get a trace from an Android release build.

[xunjieli, 2017-04-06 21:29:06]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 21:29:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 21:45:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 21:45:07]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[xunjieli, 2017-04-06 22:03:58]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 22:05:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 23:28:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 23:28:43]

Dry run: This issue passed the CQ dry run.

[ssid, 2017-04-07 17:14:04]

I'm good as long as we don't regress performance of the provider. lgtm

https://codereview.chromium.org/2807493002/diff/20001/net/http/disk_cache_bas...
File net/http/disk_cache_based_quic_server_info.cc (right):

https://codereview.chromium.org/2807493002/diff/20001/net/http/disk_cache_bas...
net/http/disk_cache_based_quic_server_info.cc:194: (write_buffer_ == nullptr ? 0
: read_buffer_->size()) +
write_buffer_?

https://codereview.chromium.org/2807493002/diff/20001/net/quic/chromium/quic_...
File net/quic/chromium/quic_stream_factory.cc (right):

https://codereview.chromium.org/2807493002/diff/20001/net/quic/chromium/quic_...
net/quic/chromium/quic_stream_factory.cc:71: // in tracking IPAliasMap.
4 bytes of dynamic memory sounds too low to add some extra code? Should we just
return 0 instead of trying to add comment about 4 bytes?

[xunjieli, 2017-04-07 21:36:22]

Patchset #3 (id:60001) has been deleted

[xunjieli, 2017-04-07 21:37:48]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[xunjieli, 2017-04-07 21:37:59]

Thanks!

https://codereview.chromium.org/2807493002/diff/20001/net/http/disk_cache_bas...
File net/http/disk_cache_based_quic_server_info.cc (right):

https://codereview.chromium.org/2807493002/diff/20001/net/http/disk_cache_bas...
net/http/disk_cache_based_quic_server_info.cc:194: (write_buffer_ == nullptr ? 0
: read_buffer_->size()) +
On 2017/04/07 17:14:04, ssid wrote:
> write_buffer_?

Done.

https://codereview.chromium.org/2807493002/diff/20001/net/quic/chromium/quic_...
File net/quic/chromium/quic_stream_factory.cc (right):

https://codereview.chromium.org/2807493002/diff/20001/net/quic/chromium/quic_...
net/quic/chromium/quic_stream_factory.cc:71: // in tracking IPAliasMap.
On 2017/04/07 17:14:04, ssid wrote:
> 4 bytes of dynamic memory sounds too low to add some extra code? Should we
just
> return 0 instead of trying to add comment about 4 bytes?

Done.

[commit-bot: I haz the power, 2017-04-07 21:38:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 22:59:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 22:59:19]

Dry run: This issue passed the CQ dry run.

[xunjieli, 2017-04-11 15:13:54]

zhongyi@: a friendly ping!

[Zhongyi Shi, 2017-04-11 18:04:39]

lgtm, thanks for doing this!

https://codereview.chromium.org/2807493002/diff/80001/net/quic/chromium/quic_...
File net/quic/chromium/quic_stream_factory.cc (right):

https://codereview.chromium.org/2807493002/diff/80001/net/quic/chromium/quic_...
net/quic/chromium/quic_stream_factory.cc:70: // Returns the estimate of
dynamically allocated memory of an IPEndPoint. Used
nit: Returns the estimate of dynamically allocated memory of an IPEndPoint in
bytes. ...

[xunjieli, 2017-04-11 21:51:45]

Thanks!

https://codereview.chromium.org/2807493002/diff/80001/net/quic/chromium/quic_...
File net/quic/chromium/quic_stream_factory.cc (right):

https://codereview.chromium.org/2807493002/diff/80001/net/quic/chromium/quic_...
net/quic/chromium/quic_stream_factory.cc:70: // Returns the estimate of
dynamically allocated memory of an IPEndPoint. Used
On 2017/04/11 18:04:39, Zhongyi Shi wrote:
> nit: Returns the estimate of dynamically allocated memory of an IPEndPoint in
> bytes. ...

Done.

[xunjieli, 2017-04-11 21:51:58]

The CQ bit was checked by xunjieli@chromium.org

[xunjieli, 2017-04-11 21:51:58]

The patchset sent to the CQ was uploaded after l-g-t-m from ssid@chromium.org,
zhongyi@chromium.org
Link to the patchset: https://codereview.chromium.org/2807493002/#ps100001
(title: "address zhongyi@ comment")

[commit-bot: I haz the power, 2017-04-11 21:52:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 23:06:57]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1491947518213290,
"parent_rev": "cae9c010f6e47a9b306f10b8889f86a65b6e9cb0", "commit_rev":
"48e4f10eb4784c4cf1bd09efde38a86457faece2"}

[commit-bot: I haz the power, 2017-04-11 23:07:50]

Description was changed from

==========
Track STL containers in QuicStreamFactory::DumpMemoryStats

This CL includes QuicStreamFactory's STL containers in 
DumpMemoryStats(). This should let us know if any of them
grows too big and causes problems.

BUG=704953
==========

to

==========
Track STL containers in QuicStreamFactory::DumpMemoryStats

This CL includes QuicStreamFactory's STL containers in 
DumpMemoryStats(). This should let us know if any of them
grows too big and causes problems.

BUG=704953

Review-Url: https://codereview.chromium.org/2807493002
Cr-Commit-Position: refs/heads/master@{#463821}
Committed:
https://chromium.googlesource.com/chromium/src/+/48e4f10eb4784c4cf1bd09efde38...
==========

[commit-bot: I haz the power, 2017-04-11 23:07:51]

Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/48e4f10eb4784c4cf1bd09efde38...