Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: ash/common/shelf/shelf_view.cc

Issue 2807473003: Shelf: Hide overflow bubble when app launched from overflow. (Closed)
Patch Set: Fixed patch set 1 errors. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/shelf/shelf_view_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/shelf/shelf_view.cc
diff --git a/ash/common/shelf/shelf_view.cc b/ash/common/shelf/shelf_view.cc
index d99b9e76fdbea9a0df593b57f7a6eec0da50f799..cc4b5d46c26ad363eb268c54173ccb309ce10391 100644
--- a/ash/common/shelf/shelf_view.cc
+++ b/ash/common/shelf/shelf_view.cc
@@ -476,6 +476,16 @@ void ShelfView::ButtonPressed(views::Button* sender,
break;
}
+ // If this is the overflow shelf, |main_shelf_| will not be null. When an item
+ // is pressed on the overflow shelf, we want to hide the overflow bubble,
+ // which is associated with the main shelf. Note: this will invalidate
msw 2017/04/06 23:19:03 nit: remove this Note, or rephrase as "Hiding the
sammiequon 2017/04/06 23:34:46 Removed.
+ // |sender| as it is a child of the overflow shelf, but it is released
+ // asynchronously.
+ if (main_shelf_) {
+ if (main_shelf_->IsShowingOverflowBubble())
+ main_shelf_->ToggleOverflowBubble();
+ }
+
const int64_t display_id = window->GetDisplayNearestWindow().id();
// Notify the item of its selection; handle the result in AfterItemSelected.
« no previous file with comments | « no previous file | ash/shelf/shelf_view_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698