Shelf: Hide overflow bubble when app launched from overflow.

ash/common/shelf/shelf_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/shelf/shelf_view.h"
 
 #include <algorithm>
 #include <memory>
 
 #include "ash/common/ash_constants.h"
@@ skipping 458 matching lines @@
 
     case TYPE_APP_PANEL:
     case TYPE_DIALOG:
       break;
 
     case TYPE_UNDEFINED:
       NOTREACHED() << "ShelfItemType must be set.";
       break;
   }
 
+  // If this is the overflow shelf, |main_shelf_| will not be null. When an item
+  // is pressed on the overflow shelf, we want to hide the overflow bubble,
+  // which is associated with the main shelf. Note: this will invalidate

[msw, 2017/04/06 23:19:03]

nit: remove this Note, or rephrase as "Hiding the bubble posts a task to close
the widget, so this object is not synchronously destroyed and member access
below is allowed." (but really there's no need for the comment)

[sammiequon, 2017/04/06 23:34:46]

Removed.

+  // |sender| as it is a child of the overflow shelf, but it is released
+  // asynchronously.
+  if (main_shelf_) {
+    if (main_shelf_->IsShowingOverflowBubble())
+      main_shelf_->ToggleOverflowBubble();
+  }
+
   const int64_t display_id = window->GetDisplayNearestWindow().id();
 
   // Notify the item of its selection; handle the result in AfterItemSelected.
   const ShelfItem& item = model_->items()[last_pressed_index_];
   model_->GetShelfItemDelegate(item.id)->ItemSelected(
       ui::Event::Clone(event), display_id, LAUNCH_FROM_UNKNOWN,
       base::Bind(&ShelfView::AfterItemSelected, weak_factory_.GetWeakPtr(),
                  item, sender, base::Passed(ui::Event::Clone(event)),
                  ink_drop));
 }
@@ skipping 1268 matching lines @@
 
 int ShelfView::CalculateShelfDistance(const gfx::Point& coordinate) const {
   const gfx::Rect bounds = GetBoundsInScreen();
   int distance = wm_shelf_->SelectValueForShelfAlignment(
       bounds.y() - coordinate.y(), coordinate.x() - bounds.right(),
       bounds.x() - coordinate.x());
   return distance > 0 ? distance : 0;
 }
 
 }  // namespace ash