Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: tools/gn/args.cc

Issue 2807463004: GN: aix port along with linux_s390x, linux_ppc64 and linux_ppc64le support. (Closed)
Patch Set: rebased, cleaned up the code, addressed comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/args.cc
diff --git a/tools/gn/args.cc b/tools/gn/args.cc
index 3bb40b415743d7fc422230e56adf898ceba5c43e..800996bd267b8569e2063899ccdc93312cbf54c2 100644
--- a/tools/gn/args.cc
+++ b/tools/gn/args.cc
@@ -302,6 +302,8 @@ void Args::SetSystemVarsLocked(Scope* dest) const {
os = "android";
#elif defined(OS_NETBSD)
os = "netbsd";
+#elif defined(OS_AIX)
+ os = "aix";
#else
#error Unknown OS type.
#endif
@@ -331,7 +333,10 @@ void Args::SetSystemVarsLocked(Scope* dest) const {
arch = kMips;
else if (os_arch == "s390x")
arch = kS390X;
- else if (os_arch == "mips")
+ else if (os_arch == "ppc64" || os_arch == "ppc64le")
+ // We handle the endianness inside //build/config/host_byteorder.gni.
Nico 2017/04/25 18:50:40 I don't see a host_byteorder.gni. I don't think we
Dirk Pranke 2017/04/25 18:53:37 See https://codereview.chromium.org/2815453004/ wh
rayb 2017/04/25 22:40:17 Acknowledged.
+ // This allows us to use the same toolchain as ppc64 BE
+ // and specific flags are included using the host_byteorder logic.
arch = kPPC64;
else
CHECK(false) << "OS architecture not handled. (" << os_arch << ")";

Powered by Google App Engine
This is Rietveld 408576698