GN: aix port along with linux_s390x, linux_ppc64 and linux_ppc64le support.

base/trace_event/process_memory_dump.cc

Index: base/trace_event/process_memory_dump.cc
diff --git a/base/trace_event/process_memory_dump.cc b/base/trace_event/process_memory_dump.cc
index 63d1340e42e3222c3ee99e92a7e676279cffb8a1..9f710936e1405f2b4215761ab0d357d75b7dbd8d 100644
--- a/base/trace_event/process_memory_dump.cc
+++ b/base/trace_event/process_memory_dump.cc
@@ -121,7 +121,12 @@ size_t ProcessMemoryDump::CountResidentBytes(void* start_address,
     // HANDLE_EINTR tries for 100 times. So following the same pattern.
     do {
       result =
+#if defined(OS_AIX)
+          mincore(reinterpret_cast<char*>(chunk_start), chunk_size,
+                  reinterpret_cast<char*>(vec.get()));

[Nico, 2017/04/25 18:50:40]

vec is a unique_ptr<char[]>, why do you need to reinterpret_cast it to char*?

[rayb, 2017/04/25 22:40:17]

On AIX mincore is defined as the following inside sys/mman.h -

extern int mincore(char *, size_t, char *);

Whereas on Linux it's defined as -

extern int mincore (void *__start, size_t __len, unsigned char *__vec).

So without the reinterpret_cast, it generates a compiler error(invalid
conversion from 'std::unique_ptr<unsigned char []>::pointer {aka unsigned
char*}' to 'char*').

+#else
           mincore(reinterpret_cast<void*>(chunk_start), chunk_size, vec.get());
+#endif
     } while (result == -1 && errno == EAGAIN && error_counter++ < 100);
     failure = !!result;