Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: base/trace_event/process_memory_dump.cc

Issue 2807463004: GN: aix port along with linux_s390x, linux_ppc64 and linux_ppc64le support. (Closed)
Patch Set: rebased, cleaned up the code, addressed comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/process_memory_dump.cc
diff --git a/base/trace_event/process_memory_dump.cc b/base/trace_event/process_memory_dump.cc
index 63d1340e42e3222c3ee99e92a7e676279cffb8a1..9f710936e1405f2b4215761ab0d357d75b7dbd8d 100644
--- a/base/trace_event/process_memory_dump.cc
+++ b/base/trace_event/process_memory_dump.cc
@@ -121,7 +121,12 @@ size_t ProcessMemoryDump::CountResidentBytes(void* start_address,
// HANDLE_EINTR tries for 100 times. So following the same pattern.
do {
result =
+#if defined(OS_AIX)
+ mincore(reinterpret_cast<char*>(chunk_start), chunk_size,
+ reinterpret_cast<char*>(vec.get()));
Nico 2017/04/25 18:50:40 vec is a unique_ptr<char[]>, why do you need to re
rayb 2017/04/25 22:40:17 On AIX mincore is defined as the following inside
+#else
mincore(reinterpret_cast<void*>(chunk_start), chunk_size, vec.get());
+#endif
} while (result == -1 && errno == EAGAIN && error_counter++ < 100);
failure = !!result;

Powered by Google App Engine
This is Rietveld 408576698