Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2807453002: Removes the chrome-proxy-ect header from M59. (Closed)

Created:
3 years, 8 months ago by dougarnett
Modified:
3 years, 8 months ago
Reviewers:
RyanSturm
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes the chrome-proxy-ect header from M59. This reverts sending the ECT header to the proxy server. Note: doing this with fresh CL seems cleaner that backing out the original 3 CLs - especially because we intend to revert this CL to put back the ECT header after the M59 branch is cut. [This is an alternative to gating behind a Feature in cl 2802463002] BUG=707981 Review-Url: https://codereview.chromium.org/2807453002 Cr-Commit-Position: refs/heads/master@{#462632} Committed: https://chromium.googlesource.com/chromium/src/+/46aa9d9db9c0581937a96ced13747039fffe943c

Patch Set 1 #

Messages

Total messages: 13 (8 generated)
dougarnett
From meeting today we decided to delete ECT code and then patch back after branch ...
3 years, 8 months ago (2017-04-06 19:08:55 UTC) #4
RyanSturm
lgtm. You can either land it now, or just before branch (the revert might be ...
3 years, 8 months ago (2017-04-06 19:16:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807453002/1
3 years, 8 months ago (2017-04-06 20:25:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/46aa9d9db9c0581937a96ced13747039fffe943c
3 years, 8 months ago (2017-04-06 21:46:16 UTC) #12
dougarnett
3 years, 8 months ago (2017-04-17 19:38:37 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2827523002/ by dougarnett@chromium.org.

The reason for reverting is: Returning the chrome-proxy-ect header code to head
of tree now that M59 branch has been made (per plan with this CL)..

Powered by Google App Engine
This is Rietveld 408576698