Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2807423002: Add color correct rendering to about:flags (Closed)

Created:
3 years, 8 months ago by ccameron
Modified:
3 years, 8 months ago
Reviewers:
msarett1, Nico, Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add color correct rendering to about:flags This feature will be enabled slowly across all platforms, and eventually will be on by default for everyone. Leave this as a tri-state option (default, enable, disable), although at the moment is never on by default. BUG=667431 Review-Url: https://codereview.chromium.org/2807423002 Cr-Commit-Position: refs/heads/master@{#464683} Committed: https://chromium.googlesource.com/chromium/src/+/c570ec9ef30d7e956a199fc309f6ff6642637f58

Patch Set 1 #

Patch Set 2 : Fix histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -3 lines) Patch
M chrome/browser/about_flags.cc View 1 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 3 chunks +5 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (12 generated)
ccameron
ptal With the changes we have in line to be committed, this is a meaningful ...
3 years, 8 months ago (2017-04-11 06:35:28 UTC) #2
Ilya Sherman
lgtm
3 years, 8 months ago (2017-04-11 21:38:56 UTC) #3
msarett1
lgtm
3 years, 8 months ago (2017-04-12 13:00:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807423002/1
3 years, 8 months ago (2017-04-13 22:47:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/429728)
3 years, 8 months ago (2017-04-13 23:25:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807423002/20001
3 years, 8 months ago (2017-04-14 05:32:24 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/c570ec9ef30d7e956a199fc309f6ff6642637f58
3 years, 8 months ago (2017-04-14 05:38:11 UTC) #18
Nico
3 years, 8 months ago (2017-04-14 14:17:25 UTC) #20
Message was sent while issue was closed.
As said on that other thread, can you please send an intent to implement for
this to blink-dev

Powered by Google App Engine
This is Rietveld 408576698