Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2807343004: Update timezone db to 2017b (Closed)

Created:
3 years, 8 months ago by jungshik at Google
Modified:
3 years, 8 months ago
Reviewers:
Michael Achenbach
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
icu
Visibility:
Public.

Description

Update timezone db to 2017b See http://mm.icann.org/pipermail/tz-announce/2017-March/000046.html for details. - Haiti resumed observing DST. Data file size changes: android/icudtl.dat 6573792 => 6573872 common/icudt*.dat 10130480 => 10130560 BUG=473288 TEST=Try the following in d8 or Chrome's JS console: > (new Date("3/12/2016 12:00Z")).toLocaleString("en", {timeZone: "America/Port-au-Prince"}) "3/12/2016, 7:00:00 AM" > (new Date("3/12/2017 12:00Z")).toLocaleString("en", {timeZone: "America/Port-au-Prince"}) "3/12/2017, 8:00:00 AM" Committed: https://chromium.googlesource.com/chromium/deps/icu/+/b34251f8b762f8e2112a89c587855ca4297fed96

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -26 lines) Patch
M android/icudtl.dat View Binary file 0 comments Download
M common/icudtb.dat View Binary file 0 comments Download
M common/icudtl.dat View Binary file 0 comments Download
M source/data/misc/zoneinfo64.txt View 4 chunks +32 lines, -26 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
jungshik at Google
Committed patchset #1 (id:1) manually as b34251f8b762f8e2112a89c587855ca4297fed96 (presubmit successful).
3 years, 8 months ago (2017-04-11 23:08:12 UTC) #5
Michael Achenbach
FYI: This seems to lead to failures when rolling into V8: https://chromium-review.googlesource.com/c/475165/ In particular: https://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered/builds/22348 ...
3 years, 8 months ago (2017-04-12 07:40:25 UTC) #7
Michael Achenbach
On 2017/04/12 07:40:25, Michael Achenbach wrote: > FYI: This seems to lead to failures when ...
3 years, 8 months ago (2017-04-12 07:41:41 UTC) #8
Dan Ehrenberg
On 2017/04/12 07:41:41, Michael Achenbach wrote: > On 2017/04/12 07:40:25, Michael Achenbach wrote: > > ...
3 years, 8 months ago (2017-04-12 10:10:21 UTC) #9
Michael Achenbach
3 years, 8 months ago (2017-04-12 12:23:13 UTC) #10
Message was sent while issue was closed.
On 2017/04/12 10:10:21, Dan Ehrenberg wrote:
> On 2017/04/12 07:41:41, Michael Achenbach wrote:
> > On 2017/04/12 07:40:25, Michael Achenbach wrote:
> > > FYI: This seems to lead to failures when rolling into V8:
> > > https://chromium-review.googlesource.com/c/475165/
> > > 
> > > In particular:
> > >
> >
>
https://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggere...
> > > 
> > > @littledan: Should we disable the failing tests for now to get the roll
> > through?
> > 
> > I'm not certain that it's from this change. Could be anything in range:
> > https://chromium.googlesource.com/chromium/deps/icu/+log/450be73..b34251f
> 
> I don't know whether it's this or the ICU roll. I don't see any relevant
recent
> changes in the tz database FWIW. Either way, the new test outcomes seem
> reasonable to me; I'm fine with disabling the tests for you to do the roll,
and
> then updating the expectations to match the output in a follow-on patch.
(FWIW,
> tangentially related spec open issue:
https://github.com/tc39/ecma402/issues/121
> -- we may have to leave the ICU tests marked failing due to this.)

FYI, filed http://crbug.com/v8/6252 and handling it there.

Powered by Google App Engine
This is Rietveld 408576698