Issue 2807313002: Allow Panner.refDistance to be 0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2807313002: Allow Panner.refDistance to be 0 (Closed)

Created:
3 years, 8 months ago by Raymond Toy

Modified:
3 years, 8 months ago

Reviewers:
hongchan

CC:
chromium-reviews, blink-reviews, haraken, kinuko+watch, Raymond Toy, hongchan

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

Allow Panner.refDistance to be 0 Reverts the change that required refDistance to be strictly positive. This was updated in the spec in issue https://github.com/WebAudio/web-audio-api/issues/1105, fixed by https://github.com/WebAudio/web-audio-api/pull/1150 BUG=672156 TEST=Panner/panner-distance-clamping.html

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -11 lines)			Patch
M	third_party/WebKit/LayoutTests/webaudio/Panner/panner-distance-clamping.html	View	1	3 chunks	+24 lines, -10 lines	0 comments	Download
M	third_party/WebKit/Source/modules/webaudio/PannerNode.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/platform/audio/Distance.cpp	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 6 (3 generated)

commit-bot: I haz the power

3 years, 8 months ago (2017-04-12 16:30:02 UTC) #5

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...