third_party/WebKit/Source/modules/webaudio/PannerNode.cpp - Issue 2807313002: Allow Panner.refDistance to be 0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/PannerNode.cpp

Issue 2807313002: Allow Panner.refDistance to be 0 (Closed)

Patch Set: Adjust test to support cases where 0 is allowed (or not) Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webaudio/PannerNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp b/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp

index fb400a2a0b5b1d14a38e99bfa6c12f4997ceb598..10aab165b4ab047cb83bcdcc446c2e98fd4999be 100644

--- a/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp

@@ -748,7 +748,7 @@ double PannerNode::refDistance() const {

void PannerNode::setRefDistance(double distance,

ExceptionState& exception_state) {

- if (distance <= 0) {

+ if (distance < 0) {

exception_state.ThrowDOMException(

kV8RangeError, ExceptionMessages::IndexExceedsMinimumBound<double>(

"refDistance", distance, 0));