[regexp] Add tests for binary property classes.

[regexp] Add tests for binary property classes.

See https://tc39.github.io/proposal-regexp-unicode-property-escapes

R=jgruber@chromium.org
BUG=v8:4743
Review-Url: https://codereview.chromium.org/2807293003
Cr-Commit-Position: refs/heads/master@{#44577}
Committed: https://chromium.googlesource.com/v8/v8/+/eee279257a13a60abc40d0b7254a25fe7bf576e4

[Yang, 2017-04-11 12:57:14]

Please take a look.

There are a few binary properties not provided by ICU. I wonder what we should
do with these.

[mathias, 2017-04-11 13:07:43]

mathias@qiwi.be changed reviewers:
+ mathias@qiwi.be

[mathias, 2017-04-11 13:07:45]

LGTM.

I wonder why ICU doesn’t support some of these properties. Any ideas?
 I’ve left some inline comments to clarify what I do know.

https://codereview.chromium.org/2807293003/diff/1/test/mjsunit/harmony/regexp...
File test/mjsunit/harmony/regexp-property-binary.js (right):

https://codereview.chromium.org/2807293003/diff/1/test/mjsunit/harmony/regexp...
test/mjsunit/harmony/regexp-property-binary.js:47: //f(/\p{CE}/u, "1");
From http://unicode.org/reports/tr44/#Decompositions_and_Normalization (emphasis
added):

> In contrast, some normalization-related Unicode character properties are *not
> recommended for exposure in a public library API*. Notably, these include
> Decomposition_Mapping, Composition_Exclusion, and the derived
> Full_Composition_Exclusion.

This could explain why `Composition_Exclusion` isn’t supported, except then
you’d expect that `Full_Composition_Exclusion` wouldn’t be supported, either
(but it is).

https://codereview.chromium.org/2807293003/diff/1/test/mjsunit/harmony/regexp...
test/mjsunit/harmony/regexp-property-binary.js:65: // f(/\p{Emoji_Component}/u,
"x");
It makes sense for ICU not to support `Emoji_Component` yet as it’s still a
draft. The ECMAScript proposal still includes it (for now) as the property
should officially be published by the time it advances to Stage 4.

https://codereview.chromium.org/2807293003/diff/1/test/mjsunit/harmony/regexp...
test/mjsunit/harmony/regexp-property-binary.js:128: // f(/\p{PCM}/u, "A");
I can’t think of a reason for ICU not to support this one.
`Prepended_Concatenation_Mark` was added only recently (Unicode 9) — maybe ICU
just forgot to add support for this property?

[Yang, 2017-04-11 13:15:33]

yangguo@chromium.org changed reviewers:
+ jshin@chromium.org

[Yang, 2017-04-11 13:15:34]

We are currently at ICU 58. But the newest ICU 59 doesn't have these binary
properties either:

- Composition_Exclusion
- Emoji_Component
- Prepended_Concatenation_Mark

Jungshik, do you have any idea why this is not implemented in ICU?

[jgruber, 2017-04-11 13:34:36]

lgtm

[Yang, 2017-04-11 13:36:26]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2017-04-11 13:36:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 14:06:46]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491917786692190, "parent_rev":
"9679a3661f4e3a3dd40bf9fdf6ab6a3a6883333d", "commit_rev":
"eee279257a13a60abc40d0b7254a25fe7bf576e4"}

[commit-bot: I haz the power, 2017-04-11 14:06:51]

Description was changed from

==========
[regexp] Add tests for binary property classes.

See https://tc39.github.io/proposal-regexp-unicode-property-escapes

R=jgruber@chromium.org
BUG=v8:4743
==========

to

==========
[regexp] Add tests for binary property classes.

See https://tc39.github.io/proposal-regexp-unicode-property-escapes

R=jgruber@chromium.org
BUG=v8:4743

Review-Url: https://codereview.chromium.org/2807293003
Cr-Commit-Position: refs/heads/master@{#44577}
Committed:
https://chromium.googlesource.com/v8/v8/+/eee279257a13a60abc40d0b7254a25fe7bf...
==========

[commit-bot: I haz the power, 2017-04-11 14:06:52]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/eee279257a13a60abc40d0b7254a25fe7bf...