components/cronet/tools/cr_cronet.py - Issue 2807283002: [Cronet] Build static libcronet.a for iOS with complete dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/tools/cr_cronet.py

Issue 2807283002: [Cronet] Build static libcronet.a for iOS with complete dependencies. (Closed)

Patch Set: Use libtool to combine i386 Cronet library and its dependencies. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/cronet/tools/cr_cronet.py

diff --git a/components/cronet/tools/cr_cronet.py b/components/cronet/tools/cr_cronet.py

index a0d111ccef3280e1099fbbdbde32b7013f8533cb..6ee58f16db9e2c57f834d22ff94560c15ec224c6 100755

--- a/components/cronet/tools/cr_cronet.py

+++ b/components/cronet/tools/cr_cronet.py

@@ -87,7 +87,7 @@ def main():

gn_args += ' target_cpu="arm64" '

out_dir_suffix = '-iphoneos'

else:

- gn_args += ' target_cpu="x64" '

+ gn_args += ' target_cpu="x86" '

kapishnikov 2017/05/23 21:37:46 Is "x64" a better default choice?

mef 2017/05/24 21:36:59 Done. Spurious edit from my experiments.

Hiroshi Ichikawa 2017/05/25 02:28:32 Looks like this is still not fixed with Patch Set

mef 2017/05/25 14:53:27 Done. Switching between two computers lost some ch

out_dir_suffix = '-iphonesimulator'

if options.asan:

gn_args += ' is_asan=true use_xcode_clang=true '