Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: components/cronet/tools/cr_cronet.py

Issue 2807283002: [Cronet] Build static libcronet.a for iOS with complete dependencies. (Closed)
Patch Set: Use libtool to combine i386 Cronet library and its dependencies. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 # Copyright 2014 The Chromium Authors. All rights reserved. 2 # Copyright 2014 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """ 6 """
7 cr_cronet.py - cr - like helper tool for cronet developers 7 cr_cronet.py - cr - like helper tool for cronet developers
8 """ 8 """
9 9
10 import argparse 10 import argparse
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 if is_os: 80 if is_os:
81 target_os = 'ios' 81 target_os = 'ios'
82 test_target = 'cronet_test' 82 test_target = 'cronet_test'
83 gn_args = 'is_cronet_build=true is_component_build=false ' \ 83 gn_args = 'is_cronet_build=true is_component_build=false ' \
84 'use_xcode_clang=true ' 84 'use_xcode_clang=true '
85 gn_extra = '--ide=xcode' 85 gn_extra = '--ide=xcode'
86 if options.iphoneos: 86 if options.iphoneos:
87 gn_args += ' target_cpu="arm64" ' 87 gn_args += ' target_cpu="arm64" '
88 out_dir_suffix = '-iphoneos' 88 out_dir_suffix = '-iphoneos'
89 else: 89 else:
90 gn_args += ' target_cpu="x64" ' 90 gn_args += ' target_cpu="x86" '
kapishnikov 2017/05/23 21:37:46 Is "x64" a better default choice?
mef 2017/05/24 21:36:59 Done. Spurious edit from my experiments.
Hiroshi Ichikawa 2017/05/25 02:28:32 Looks like this is still not fixed with Patch Set
mef 2017/05/25 14:53:27 Done. Switching between two computers lost some ch
91 out_dir_suffix = '-iphonesimulator' 91 out_dir_suffix = '-iphonesimulator'
92 if options.asan: 92 if options.asan:
93 gn_args += ' is_asan=true use_xcode_clang=true ' 93 gn_args += ' is_asan=true use_xcode_clang=true '
94 out_dir_suffix += '-asan' 94 out_dir_suffix += '-asan'
95 else: 95 else:
96 target_os = 'android' 96 target_os = 'android'
97 test_target = 'cronet_test_instrumentation_apk' 97 test_target = 'cronet_test_instrumentation_apk'
98 gn_args = 'use_errorprone_java_compiler=true arm_use_neon=false ' 98 gn_args = 'use_errorprone_java_compiler=true arm_use_neon=false '
99 gn_extra = '' 99 gn_extra = ''
100 out_dir_suffix = '' 100 out_dir_suffix = ''
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 return test_ios(out_dir, extra_options) 148 return test_ios(out_dir, extra_options)
149 if (options.command=='build-test'): 149 if (options.command=='build-test'):
150 return build(out_dir, test_target) or test_ios(out_dir, extra_options) 150 return build(out_dir, test_target) or test_ios(out_dir, extra_options)
151 151
152 parser.print_help() 152 parser.print_help()
153 return 1 153 return 1
154 154
155 155
156 if __name__ == '__main__': 156 if __name__ == '__main__':
157 sys.exit(main()) 157 sys.exit(main())
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698