[inspector] store creation stack in current V8StackTraceImpl

[inspector] store creation stack in current V8StackTraceImpl

We currently store it in parent stack trace but stacks with the same parent can have different creations stacks.

BUG=v8:6189
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2807273002
Cr-Commit-Position: refs/heads/master@{#44624}
Committed: https://chromium.googlesource.com/v8/v8/+/aee49387f7fc9a79fd7209b5c1012532a14f6de5

[kozy, 2017-04-10 19:50:39]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 19:50:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2017-04-10 19:50:52]

Dmitry, please take a look!

[commit-bot: I haz the power, 2017-04-10 19:53:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 19:53:10]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/24251)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/20746)

[kozy, 2017-04-10 20:09:04]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 20:09:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 20:28:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 20:28:38]

Dry run: Try jobs failed on following builders:
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)
  v8_linux_verify_csa_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng_...)

[kozy, 2017-04-10 20:41:45]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 20:41:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 21:06:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 21:06:49]

Dry run: This issue passed the CQ dry run.

[kozy, 2017-04-11 04:06:51]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 04:06:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 04:43:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 04:43:06]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-04-11 19:00:42]

https://codereview.chromium.org/2807273002/diff/80001/src/inspector/v8-debugg...
File src/inspector/v8-debugger.h (right):

https://codereview.chromium.org/2807273002/diff/80001/src/inspector/v8-debugg...
src/inspector/v8-debugger.h:80: V8StackTraceImpl* currentCreationStack();
currentAsyncTaskCreationStack

https://codereview.chromium.org/2807273002/diff/80001/src/inspector/v8-stack-...
File src/inspector/v8-stack-trace-impl.cc (right):

https://codereview.chromium.org/2807273002/diff/80001/src/inspector/v8-stack-...
src/inspector/v8-stack-trace-impl.cc:123: if (frames.empty() && !creationStack
&& !asyncCallChain) return nullptr;
Move this below next safety check please.

https://codereview.chromium.org/2807273002/diff/80001/src/inspector/v8-stack-...
src/inspector/v8-stack-trace-impl.cc:265: debugger,
debugger->currentAsyncCallChain()->m_contextGroupId,
currentAsyncCallChain() could be null.

https://codereview.chromium.org/2807273002/diff/80001/test/inspector/runtime/...
File test/inspector/runtime/call-function-on-async-expected.txt (left):

https://codereview.chromium.org/2807273002/diff/80001/test/inspector/runtime/...
test/inspector/runtime/call-function-on-async-expected.txt:128: stackTrace : {
Nice one, but let's actually fix this :-)

[kozy, 2017-04-12 02:21:38]

all done, please take a look!

https://codereview.chromium.org/2807273002/diff/80001/src/inspector/v8-debugg...
File src/inspector/v8-debugger.h (right):

https://codereview.chromium.org/2807273002/diff/80001/src/inspector/v8-debugg...
src/inspector/v8-debugger.h:80: V8StackTraceImpl* currentCreationStack();
On 2017/04/11 19:00:42, dgozman wrote:
> currentAsyncTaskCreationStack

Done.

https://codereview.chromium.org/2807273002/diff/80001/src/inspector/v8-stack-...
File src/inspector/v8-stack-trace-impl.cc (right):

https://codereview.chromium.org/2807273002/diff/80001/src/inspector/v8-stack-...
src/inspector/v8-stack-trace-impl.cc:123: if (frames.empty() && !creationStack
&& !asyncCallChain) return nullptr;
On 2017/04/11 19:00:42, dgozman wrote:
> Move this below next safety check please.

Done.

https://codereview.chromium.org/2807273002/diff/80001/src/inspector/v8-stack-...
src/inspector/v8-stack-trace-impl.cc:265: debugger,
debugger->currentAsyncCallChain()->m_contextGroupId,
On 2017/04/11 19:00:42, dgozman wrote:
> currentAsyncCallChain() could be null.

Done.

https://codereview.chromium.org/2807273002/diff/80001/test/inspector/runtime/...
File test/inspector/runtime/call-function-on-async-expected.txt (left):

https://codereview.chromium.org/2807273002/diff/80001/test/inspector/runtime/...
test/inspector/runtime/call-function-on-async-expected.txt:128: stackTrace : {
On 2017/04/11 19:00:42, dgozman wrote:
> Nice one, but let's actually fix this :-)

Done: https://bugs.chromium.org/p/v8/issues/detail?id=6249

[kozy, 2017-04-12 15:14:56]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 15:15:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 15:42:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 15:42:33]

Dry run: This issue passed the CQ dry run.

[kozy, 2017-04-12 16:50:52]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 16:50:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 17:15:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 17:15:24]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-04-12 18:34:25]

lgtm

[kozy, 2017-04-12 19:01:01]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-04-12 19:01:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 19:02:59]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1492023661470160,
"parent_rev": "b2dc9230c14f3b1dd6e5231457a8d157c39b8489", "commit_rev":
"aee49387f7fc9a79fd7209b5c1012532a14f6de5"}

[commit-bot: I haz the power, 2017-04-12 19:03:06]

Description was changed from

==========
[inspector] store creation stack in current V8StackTraceImpl

We currently store it in parent stack trace but stacks with the same parent can
have different creations stacks.

BUG=v8:6189
R=dgozman@chromium.org
==========

to

==========
[inspector] store creation stack in current V8StackTraceImpl

We currently store it in parent stack trace but stacks with the same parent can
have different creations stacks.

BUG=v8:6189
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2807273002
Cr-Commit-Position: refs/heads/master@{#44624}
Committed:
https://chromium.googlesource.com/v8/v8/+/aee49387f7fc9a79fd7209b5c1012532a14...
==========

[commit-bot: I haz the power, 2017-04-12 19:03:07]

Committed patchset #10 (id:180001) as
https://chromium.googlesource.com/v8/v8/+/aee49387f7fc9a79fd7209b5c1012532a14...