Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2807263002: Android: Remove GetApplicationContext for cast (Closed)

Created:
3 years, 8 months ago by Peter Wen
Modified:
3 years, 8 months ago
Reviewers:
halliwell
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, agrieve+watch_chromium.org, Simeon
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Remove GetApplicationContext for cast base/android/context_utils.* is being removed. Java-side already has the ContextUtils#GetApplicationContext global and no longer needs native to hold the pointer and pass it through jni with every call that needs an application context. BUG=646094 Review-Url: https://codereview.chromium.org/2807263002 Cr-Commit-Position: refs/heads/master@{#463384} Committed: https://chromium.googlesource.com/chromium/src/+/ee1f0a96ff9d1a4f524f88156e3fbbdb53234c1c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -27 lines) Patch
M chromecast/app/android/crash_handler.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chromecast/base/android/system_time_change_notifier_android.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chromecast/base/chromecast_config_android.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chromecast/base/java/src/org/chromium/chromecast/base/ChromecastConfigAndroid.java View 2 chunks +3 lines, -4 lines 0 comments Download
M chromecast/base/java/src/org/chromium/chromecast/base/SystemTimeChangeNotifierAndroid.java View 3 chunks +6 lines, -8 lines 0 comments Download
M chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastCrashHandler.java View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Peter Wen
Hi Luke, PTAL, see part 1 here: http://crrev.com/2772343003 part 2: http://crrev.com/2799263002 Thanks.
3 years, 8 months ago (2017-04-10 19:42:49 UTC) #2
halliwell
On 2017/04/10 19:42:49, Peter Wen wrote: > Hi Luke, PTAL, see part 1 here: http://crrev.com/2772343003 ...
3 years, 8 months ago (2017-04-10 20:08:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807263002/1
3 years, 8 months ago (2017-04-10 20:28:34 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 20:42:49 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ee1f0a96ff9d1a4f524f88156e3f...

Powered by Google App Engine
This is Rietveld 408576698