Use explicit conversion to base::Optional in MSVS::GetCurrentFormatImpl implementations.

Use explicit conversion to base::Optional in MSVS::GetCurrentFormatImpl implementations.

This is a speculative fix for a hard-to-reproduce Clusterfuzz issue with CFI builds. No behavior change intended.

BUG=709736
Review-Url: https://codereview.chromium.org/2807203002
Cr-Commit-Position: refs/heads/master@{#463603}
Committed: https://chromium.googlesource.com/chromium/src/+/46b6e63834ff622224871ea57e95901d59caad8a

[Guido Urdaneta, 2017-04-10 17:03:15]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 17:03:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 18:05:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 18:05:48]

Dry run: This issue passed the CQ dry run.

[Guido Urdaneta, 2017-04-11 10:51:20]

Description was changed from

==========
Use explicit conversion to base::Optional in MSVS::GetCurrentFormatImpl
implementations.

No behavior change intended.

BUG=709736
==========

to

==========
Use explicit conversion to base::Optional in MSVS::GetCurrentFormatImpl
implementations.

This is a speculative fix for a hard-to-reproduce Clusterfuzz issue. No behavior
change intended.

BUG=709736
==========

[Guido Urdaneta, 2017-04-11 10:53:51]

Description was changed from

==========
Use explicit conversion to base::Optional in MSVS::GetCurrentFormatImpl
implementations.

This is a speculative fix for a hard-to-reproduce Clusterfuzz issue. No behavior
change intended.

BUG=709736
==========

to

==========
Use explicit conversion to base::Optional in MSVS::GetCurrentFormatImpl
implementations.

This is a speculative fix for a hard-to-reproduce Clusterfuzz issue with CFI
builds. No behavior change intended.

BUG=709736
==========

[Guido Urdaneta, 2017-04-11 10:54:26]

guidou@chromium.org changed reviewers:
+ jochen@chromium.org

[Guido Urdaneta, 2017-04-11 10:54:27]

Hi, PTAL

[jochen (gone - plz use gerrit), 2017-04-11 12:16:38]

lgtm

[Guido Urdaneta, 2017-04-11 12:30:28]

The CQ bit was checked by guidou@chromium.org

[commit-bot: I haz the power, 2017-04-11 12:30:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 12:35:57]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491913828799620, "parent_rev":
"747b47023453d56494a69c21aa2765de9da8449b", "commit_rev":
"46b6e63834ff622224871ea57e95901d59caad8a"}

[commit-bot: I haz the power, 2017-04-11 12:36:52]

Description was changed from

==========
Use explicit conversion to base::Optional in MSVS::GetCurrentFormatImpl
implementations.

This is a speculative fix for a hard-to-reproduce Clusterfuzz issue with CFI
builds. No behavior change intended.

BUG=709736
==========

to

==========
Use explicit conversion to base::Optional in MSVS::GetCurrentFormatImpl
implementations.

This is a speculative fix for a hard-to-reproduce Clusterfuzz issue with CFI
builds. No behavior change intended.

BUG=709736

Review-Url: https://codereview.chromium.org/2807203002
Cr-Commit-Position: refs/heads/master@{#463603}
Committed:
https://chromium.googlesource.com/chromium/src/+/46b6e63834ff622224871ea57e95...
==========

[commit-bot: I haz the power, 2017-04-11 12:36:53]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/46b6e63834ff622224871ea57e95...