Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2807203002: Use explicit conversion to base::Optional in MSVS::GetCurrentFormatImpl implementations. (Closed)

Created:
3 years, 8 months ago by Guido Urdaneta
Modified:
3 years, 8 months ago
CC:
avayvod+watch_chromium.org, chfremer+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, imcheng+watch_chromium.org, isheriff+watch_chromium.org, jam, jasonroberts+watch_google.com, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use explicit conversion to base::Optional in MSVS::GetCurrentFormatImpl implementations. This is a speculative fix for a hard-to-reproduce Clusterfuzz issue with CFI builds. No behavior change intended. BUG=709736 Review-Url: https://codereview.chromium.org/2807203002 Cr-Commit-Position: refs/heads/master@{#463603} Committed: https://chromium.googlesource.com/chromium/src/+/46b6e63834ff622224871ea57e95901d59caad8a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M content/renderer/media/media_stream_video_capturer_source.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/mock_media_stream_video_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_media_stream_video_track_host.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Guido Urdaneta
Hi, PTAL
3 years, 8 months ago (2017-04-11 10:54:27 UTC) #8
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-04-11 12:16:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807203002/1
3 years, 8 months ago (2017-04-11 12:30:42 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 12:36:53 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/46b6e63834ff622224871ea57e95...

Powered by Google App Engine
This is Rietveld 408576698