Issue 28072: Make non-glass popups match new mockup from Glen....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 28072: Make non-glass popups match new mockup from Glen.... (Closed)

Created:
11 years, 10 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
Glen Murphy, Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make non-glass popups match new mockup from Glen. Unfortunately glass popups can't be made to match the mockup unless we want to completely reimplement Windows titlebar drawing, so I'm leaving them pretty much unchanged :( BUG=7569 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10341

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+102 lines, -102 lines)			Patch
M	chrome/app/theme/locationbg_readonly_center.png	View	Binary file		0 comments	Download
A +	chrome/app/theme/locationbg_readonly_edge.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/locationbg_readonly_left.png	View	Binary file		0 comments	Download
D	chrome/app/theme/locationbg_readonly_right.png	View	Binary file		0 comments	Download
M	chrome/app/theme/theme_resources.grd	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/views/frame/aero_glass_non_client_view.cc	View	1 chunk	+5 lines, -13 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/views/frame/opaque_non_client_view.h	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/views/frame/opaque_non_client_view.cc	View	11 chunks	+34 lines, -40 lines	0 comments	Download
M	chrome/browser/views/location_bar_view.h	View	1 chunk	+1 line, -8 lines	0 comments	Download
M	chrome/browser/views/location_bar_view.cc	View	3 chunks	+3 lines, -9 lines	0 comments	Download
M	chrome/browser/views/toolbar_view.h	View	4 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/browser/views/toolbar_view.cc	View	6 chunks	+46 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

OK. Can you show me before you commit?

Expand Messages | Collapse Messages