Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: chrome/browser/views/frame/aero_glass_non_client_view.cc

Issue 28072: Make non-glass popups match new mockup from Glen.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/theme/theme_resources.grd ('k') | chrome/browser/views/frame/browser_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/frame/aero_glass_non_client_view.cc
===================================================================
--- chrome/browser/views/frame/aero_glass_non_client_view.cc (revision 10201)
+++ chrome/browser/views/frame/aero_glass_non_client_view.cc (working copy)
@@ -271,21 +271,13 @@
}
void AeroGlassNonClientView::PaintClientEdge(ChromeCanvas* canvas) {
+ // The client edges start below the toolbar upper corner images regardless
+ // of how tall the toolbar itself is.
int client_area_top =
- frame_->client_view()->y() + browser_view_->GetToolbarBounds().bottom();
- gfx::Rect client_area_bounds = CalculateClientAreaBounds(width(), height());
- // The toolbar draws a client edge along its own bottom edge when it's visible
- // and in normal mode. However, it only draws this for the width of the
- // actual client area, leaving a gap at the left and right edges:
- //
- // | Toolbar | <-- part of toolbar
- // ----- (toolbar client edge) ----- <-- gap
- // | Client area | <-- right client edge
- //
- // To address this, we extend the left and right client edges up to fill the
- // gap, by pretending the toolbar is shorter than it really is.
- client_area_top -= kClientEdgeThickness;
+ frame_->client_view()->y() + browser_view_->GetToolbarBounds().y() +
+ resources_->GetPartBitmap(FRAME_CLIENT_EDGE_TOP_LEFT)->height();
+ gfx::Rect client_area_bounds = CalculateClientAreaBounds(width(), height());
int client_area_bottom =
std::max(client_area_top, height() - NonClientBorderThickness());
int client_area_height = client_area_bottom - client_area_top;
« no previous file with comments | « chrome/app/theme/theme_resources.grd ('k') | chrome/browser/views/frame/browser_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698