Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issue 2807193004: gn path: Add missing newline to output summary (Closed)

Created:
3 years, 8 months ago by michaelpg
Modified:
3 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

gn path: Add missing newline to output summary Before: > Showing one of 92 "interesting" public paths.Use --all to print all paths. After: > Showing one of 92 "interesting" public paths. > Use --all to print all paths. Visual diff with full output: http://www.mergely.com/PJ83W4M7/ BUG=none R=brettw@chromium.org Review-Url: https://codereview.chromium.org/2807193004 Cr-Commit-Position: refs/heads/master@{#465396} Committed: https://chromium.googlesource.com/chromium/src/+/a38716a1806d8b03999d77f9bbfb1e793f60f34b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/gn/command_path.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
michaelpg
3 years, 8 months ago (2017-04-12 04:10:30 UTC) #3
brettw
lgtm
3 years, 8 months ago (2017-04-18 21:29:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807193004/1
3 years, 8 months ago (2017-04-18 22:09:56 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 22:23:55 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a38716a1806d8b03999d77f9bbfb...

Powered by Google App Engine
This is Rietveld 408576698