Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2807193003: Strip only ASCII spaces from SMIL 'values' attributes (Closed)

Created:
3 years, 8 months ago by fs
Modified:
3 years, 8 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, fmalita+watch_chromium.org, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Strip only ASCII spaces from SMIL 'values' attributes This is more consistent with other microsyntaxes used for attribute parsing, while also making it consistent with the XSSAuditor. BUG=709365, 710460 Review-Url: https://codereview.chromium.org/2807193003 Cr-Commit-Position: refs/heads/master@{#463662} Committed: https://chromium.googlesource.com/chromium/src/+/cd2205139c375696291bffcf86d27ef4e83d7994

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/svg/animations/animate-values-whitespace.html View 1 chunk +59 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
fs
3 years, 8 months ago (2017-04-11 16:12:48 UTC) #5
pdr.
On 2017/04/11 at 16:12:48, fs wrote: > LGTM
3 years, 8 months ago (2017-04-11 16:45:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807193003/1
3 years, 8 months ago (2017-04-11 16:59:42 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 17:10:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cd2205139c375696291bffcf86d2...

Powered by Google App Engine
This is Rietveld 408576698