third_party/WebKit/Source/core/layout/ng/ng_text_fragment_builder.h - Issue 2807113002: [LayoutNG] Use NGLogical[Offset|Size] for NGFragment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_text_fragment_builder.h

Issue 2807113002: [LayoutNG] Use NGLogical[Offset|Size] for NGFragment

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/ng/geometry/ng_physical_offset.cc ('K') | « third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_text_fragment_builder.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_text_fragment_builder.h b/third_party/WebKit/Source/core/layout/ng/ng_text_fragment_builder.h

index 6f7eddc539948f3e09478ba9871d911f1266106f..08de8af384507cbadce066b48252e0683dc150fd 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_text_fragment_builder.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_text_fragment_builder.h

@@ -25,6 +25,7 @@ class CORE_EXPORT NGTextFragmentBuilder final {

NGTextFragmentBuilder& SetInlineSize(LayoutUnit);

NGTextFragmentBuilder& SetBlockSize(LayoutUnit);

+ void SetSize(NGLogicalSize size) { size_ = size; }

void UniteMetrics(const NGLineHeightMetrics&);

const NGLineHeightMetrics& Metrics() const { return metrics_; }

@@ -36,11 +37,8 @@ class CORE_EXPORT NGTextFragmentBuilder final {

private:

TextDirection direction_;

Persistent<NGInlineNode> node_;

NGLogicalSize size_;

NGLineHeightMetrics metrics_;

};