third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc - Issue 2807113002: [LayoutNG] Use NGLogical[Offset|Size] for NGFragment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc

Issue 2807113002: [LayoutNG] Use NGLogical[Offset|Size] for NGFragment

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/ng/geometry/ng_physical_offset.cc ('K') | « third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_text_fragment_builder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc b/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc

index 3ab50d5f7b21d187658e47faa0b03afcb0a05bbb..a66e4812833536dd22753f0312666460d866522b 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc

@@ -129,7 +129,7 @@ RefPtr<NGLayoutResult> NGOutOfFlowLayoutPart::LayoutDescendant(

descendant_writing_mode,

ToNGPhysicalBoxFragment(layout_result->PhysicalFragment().Get()));

- block_estimate = fragment.BlockSize();

+ block_estimate = fragment.Size().block_size;

}

ComputeFullAbsoluteWithChildBlockSize(*container_space_, descendant.Style(),