Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2807063009:
Fix typo in Linux Files.cfg (Closed)
|
Created:
3 years, 8 months ago by dimu1 Modified:
3 years, 8 months ago Reviewers:
Ken Russell (switch to Gerrit), dimu, capn, please use gerrit instead, Michael Moss, hongchan, Mike West, haraken, piman CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix typo in Linux Files.cfg
BUG=710741
TBR=mmoss@chromium.org
R=mkwst@chromium.org, rouslan@chromium.org, capn@chromium.org, haraken@chromium.org, hongchan@chromium.org
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fix typo in Linux Files.cfg #Messages
Total messages: 17 (10 generated)
https://codereview.chromium.org/2807063009/diff/1/chrome/tools/build/linux/FI... File chrome/tools/build/linux/FILES.cfg (right): https://codereview.chromium.org/2807063009/diff/1/chrome/tools/build/linux/FI... chrome/tools/build/linux/FILES.cfg:130: 'buildtype': ['dev, 'official'], I think it needs a ' after dev.
LGTM to fix the build failure.
dimu@google.com changed reviewers: + dimu@google.com
https://codereview.chromium.org/2807063009/diff/1/chrome/tools/build/linux/FI... File chrome/tools/build/linux/FILES.cfg (right): https://codereview.chromium.org/2807063009/diff/1/chrome/tools/build/linux/FI... chrome/tools/build/linux/FILES.cfg:130: 'buildtype': ['dev, 'official'], On 2017/04/12 04:38:06, capn wrote: > I think it needs a ' after dev. oops, updated a new patch.
The CQ bit was checked by dimu@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org Link to the patchset: https://codereview.chromium.org/2807063009/#ps20001 (title: "Fix typo in Linux Files.cfg")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Fix typo in Linux Files.cfg BUG=710741 R=mkwst@chromium.org, rouslan@chromium.org, capn@chromium.org, haraken@chromium.org, hongchan@chromium.org ========== to ========== Fix typo in Linux Files.cfg BUG=710741 R=mkwst@chromium.org, rouslan@chromium.org, capn@chromium.org, haraken@chromium.org, hongchan@chromium.org TBR=mmoss@chromium.org, kbr@chromium.org, piman@chromium.org ==========
dimu@google.com changed reviewers: + kbr@chromium.org, mmoss@chromium.org, piman@chromium.org
The CQ bit was checked by dimu@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491972885257930,
"parent_rev": "298ac928b50540b9bc40dfb0c510f8f8578ad4fe", "commit_rev":
"6ede719ec9e4a968c5eedafda3be94c210568d81"}
Message was sent while issue was closed.
Description was changed from ========== Fix typo in Linux Files.cfg BUG=710741 R=mkwst@chromium.org, rouslan@chromium.org, capn@chromium.org, haraken@chromium.org, hongchan@chromium.org TBR=mmoss@chromium.org, kbr@chromium.org, piman@chromium.org ========== to ========== Fix typo in Linux Files.cfg BUG=710741 R=mkwst@chromium.org, rouslan@chromium.org, capn@chromium.org, haraken@chromium.org, hongchan@chromium.org TBR=mmoss@chromium.org, kbr@chromium.org, piman@chromium.org Review-Url: https://codereview.chromium.org/2807063009 Cr-Commit-Position: refs/heads/master@{#463933} Committed: https://chromium.googlesource.com/chromium/src/+/6ede719ec9e4a968c5eedafda3be... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/6ede719ec9e4a968c5eedafda3be...
Message was sent while issue was closed.
Description was changed from ========== Fix typo in Linux Files.cfg BUG=710741 R=mkwst@chromium.org, rouslan@chromium.org, capn@chromium.org, haraken@chromium.org, hongchan@chromium.org TBR=mmoss@chromium.org, kbr@chromium.org, piman@chromium.org Review-Url: https://codereview.chromium.org/2807063009 Cr-Commit-Position: refs/heads/master@{#463933} Committed: https://chromium.googlesource.com/chromium/src/+/6ede719ec9e4a968c5eedafda3be... ========== to ========== Fix typo in Linux Files.cfg BUG=710741 TBR=mmoss@chromium.org R=mkwst@chromium.org, rouslan@chromium.org, capn@chromium.org, haraken@chromium.org, hongchan@chromium.org ========== |
