ios/chrome/browser/ui/browser_view_controller.mm - Issue 2807063006: [ios] Reduce access to private //ios/web API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2807063006: [ios] Reduce access to private //ios/web API. (Closed)

Patch Set: Call -recordStateInHistory in CRWWebController -wasHidden.' Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/browser_view_controller.mm

diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm

index 0f622e410015f4fb09f9aaefd66ceb7c2a65f59d..4bcc4daf93f34134e8a0a9c95d5504feaca384ca 100644

--- a/ios/chrome/browser/ui/browser_view_controller.mm

+++ b/ios/chrome/browser/ui/browser_view_controller.mm

@@ -1978,7 +1978,6 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {

[_toolbarController dismissToolsMenuPopup];

[self hidePageInfoPopupForView:nil];

[_toolbarController dismissTabHistoryPopup];

- [[_model currentTab] recordStateInHistory];

}

#pragma mark - Tap handling

@@ -3715,7 +3714,6 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {

[newTab navigationManager]->CanPruneAllButLastCommittedItem();

if (oldTab && newTab && canPruneItems) {

- [oldTab recordStateInHistory];

[newTab navigationManager]->CopyStateFromAndPrune(

[oldTab navigationManager]);

[[newTab nativeAppNavigationController]