Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: ios/chrome/browser/tabs/tab_model_selected_tab_observer.mm

Issue 2807063006: [ios] Reduce access to private //ios/web API. (Closed)
Patch Set: Call -recordStateInHistory in CRWWebController -wasHidden.' Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab_model.mm ('k') | ios/chrome/browser/ui/browser_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab_model_selected_tab_observer.mm
diff --git a/ios/chrome/browser/tabs/tab_model_selected_tab_observer.mm b/ios/chrome/browser/tabs/tab_model_selected_tab_observer.mm
index 5f19d6183c3039641cb996c39cea4291bc3c4fb5..92b51ebdb74bee98470a2d86fee0f7e08c595188 100644
--- a/ios/chrome/browser/tabs/tab_model_selected_tab_observer.mm
+++ b/ios/chrome/browser/tabs/tab_model_selected_tab_observer.mm
@@ -32,13 +32,10 @@
oldWebState:(web::WebState*)oldWebState
atIndex:(int)atIndex
userAction:(BOOL)userAction {
- Tab* oldTab = nil;
- Tab* newTab = nil;
if (oldWebState) {
// Save state, such as scroll position, ... of the old selected Tab.
- oldTab = LegacyTabHelper::GetTabForWebState(oldWebState);
- if (userAction)
- [oldTab recordStateInHistory];
+ Tab* oldTab = LegacyTabHelper::GetTabForWebState(oldWebState);
+ DCHECK(oldTab);
// Avoid artificially extending the lifetime of oldTab until the global
// autoreleasepool is purged.
@@ -51,7 +48,7 @@
}
if (newWebState) {
- newTab = LegacyTabHelper::GetTabForWebState(newWebState);
+ Tab* newTab = LegacyTabHelper::GetTabForWebState(newWebState);
[newTab updateLastVisitedTimestamp];
// Persist the session state.
« no previous file with comments | « ios/chrome/browser/tabs/tab_model.mm ('k') | ios/chrome/browser/ui/browser_view_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698