Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2807063003: kChildNeedsReattachLayoutTree should not be initially set. (Closed)

Created:
3 years, 8 months ago by rune
Modified:
3 years, 8 months ago
Reviewers:
nainar
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

kChildNeedsReattachLayoutTree should not be initially set. This flag should have been dropped in [1] since we dropped setting kNeedsReattachLayoutTree initially in that CL. [1] https://codereview.chromium.org/2760233004 R=nainar@chromium.org BUG=595137 Review-Url: https://codereview.chromium.org/2807063003 Cr-Commit-Position: refs/heads/master@{#463421} Committed: https://chromium.googlesource.com/chromium/src/+/83fce45beecdbd02f1e66b56fd73224f3108c34d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
rune
ptal
3 years, 8 months ago (2017-04-10 21:03:59 UTC) #5
nainar
lgtm
3 years, 8 months ago (2017-04-10 21:11:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807063003/1
3 years, 8 months ago (2017-04-10 22:23:44 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 22:31:49 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/83fce45beecdbd02f1e66b56fd73...

Powered by Google App Engine
This is Rietveld 408576698