Call elements' destructors in HashTable

Call elements' destructors in HashTable

HashTable::ExpandBuffer doesn't call elements' destructors appropriately. It
relys on a wrong assumption that it doesn't have to call the destructor on
a moved out object.

This CL fixes that.

BUG=709848
Review-Url: https://codereview.chromium.org/2807053002
Cr-Commit-Position: refs/heads/master@{#463174}
Committed: https://chromium.googlesource.com/chromium/src/+/f3e971b60293bb5f7e6bd8de03b7f3ea77a2be13

[yhirano, 2017-04-10 03:35:49]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 03:36:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-04-10 03:36:36]

Description was changed from

==========
Call elements' destructors in HashTable

HashTable::ExpandBuffer doesn't call elements' destructors appropriately. It
relys on the assumption that it doesn't have to call the destructor on a moved
out object, which is a wrong assumption.

This CL fixes that.

BUG=709848
==========

to

==========
Call elements' destructors in HashTable

HashTable::ExpandBuffer doesn't call elements' destructors appropriately. It
relys on a wrong assumption that it doesn't have to call the destructor on
a moved out object.

This CL fixes that.

BUG=709848
==========

[yhirano, 2017-04-10 03:36:36]

yhirano@chromium.org changed reviewers:
+ yutak@chromium.org

[yhirano, 2017-04-10 03:58:02]

yhirano@chromium.org changed reviewers:
+ kouhei@chromium.org

[commit-bot: I haz the power, 2017-04-10 05:14:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 05:14:26]

Dry run: This issue passed the CQ dry run.

[Yuta Kitamura, 2017-04-10 05:26:10]

I've thought about this for a while and yes, you seem right.
LGTM.

optional: Having a unit test would make this CL nicer.

[kouhei (in TOK), 2017-04-10 05:29:31]

lgtm

[yhirano, 2017-04-10 05:30:58]

> optional: Having a unit test would make this CL nicer.

I added one in HeapTest. This issue is reproducible only in HeapCollections.

[haraken, 2017-04-10 05:35:10]

LGTM

[Yuta Kitamura, 2017-04-10 05:37:39]

On 2017/04/10 05:30:58, yhirano wrote:
> > optional: Having a unit test would make this CL nicer.
> 
> I added one in HeapTest. This issue is reproducible only in HeapCollections.

Ah sorry, I was unconciously ignoring the test code. LGTM.

[yhirano, 2017-04-10 05:38:28]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2017-04-10 05:38:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 05:43:55]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491802708886510, "parent_rev":
"25921a3c76075db1aefb91ebceb216c0dd2556db", "commit_rev":
"f3e971b60293bb5f7e6bd8de03b7f3ea77a2be13"}

[commit-bot: I haz the power, 2017-04-10 05:44:40]

Description was changed from

==========
Call elements' destructors in HashTable

HashTable::ExpandBuffer doesn't call elements' destructors appropriately. It
relys on a wrong assumption that it doesn't have to call the destructor on
a moved out object.

This CL fixes that.

BUG=709848
==========

to

==========
Call elements' destructors in HashTable

HashTable::ExpandBuffer doesn't call elements' destructors appropriately. It
relys on a wrong assumption that it doesn't have to call the destructor on
a moved out object.

This CL fixes that.

BUG=709848

Review-Url: https://codereview.chromium.org/2807053002
Cr-Commit-Position: refs/heads/master@{#463174}
Committed:
https://chromium.googlesource.com/chromium/src/+/f3e971b60293bb5f7e6bd8de03b7...
==========

[commit-bot: I haz the power, 2017-04-10 05:44:42]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f3e971b60293bb5f7e6bd8de03b7...