Don't ever create a file in about:blank when launching packaged apps.

apps/launcher.cc

Index: apps/launcher.cc
diff --git a/apps/launcher.cc b/apps/launcher.cc
index e081eb185f131589133144d3a6fa50d822c4ea9e..d7c0522ff4edcdbc1c0777919753ffcce14ce944 100644
--- a/apps/launcher.cc
+++ b/apps/launcher.cc
@@ -20,6 +20,7 @@
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/web_contents.h"
+#include "content/public/common/url_constants.h"
 #include "extensions/browser/event_router.h"
 #include "extensions/browser/extension_host.h"
 #include "extensions/browser/extension_prefs.h"
@@ -351,7 +352,18 @@ void LaunchPlatformAppWithCommandLine(Profile* profile,
     }
   }
 
-  if (command_line.GetArgs().empty()) {
+#if defined(OS_WIN)
+  base::CommandLine::StringType about_blank_url(

[tapted, 2014/05/13 06:47:04]

if you don't want the #ifdef, you could use

  base::CommandLine::StringType about_blank_url(
      base::FilePath().AppendASCII(content::kAboutBlankURL).value());


.. I think. But the ifdef is fine, since that's a little weird.

+      base::ASCIIToWide(content::kAboutBlankURL));
+#else
+  base::CommandLine::StringType about_blank_url(content::kAboutBlankURL);
+#endif
+  // Browser tests will add about:blank to the command line. This should
+  // never be interpreted as a file to open, as doing so with an app that
+  // has write access will result in a file 'about' being created, which
+  // causes problems on the bots.
+  if (command_line.GetArgs().empty() ||
+      command_line.GetArgs()[0] == about_blank_url) {

[tapted, 2014/05/13 06:47:04]

Seems unfair to disallow any packaged app from opening a file called
'about:blank'.. You could also check that
command_line.HasSwitch(switches::kTestType)

command_line.GetArgs() is also a little heavyweight, and it's used again below -
maybe cache it?

i.e.

  CommandLine::StringVector args = command_line.GetArgs();
  if (args.empty() || (command_line.HasSwitch(switches::kTestType) &&
                       args[0] == about_blank_url)) {
    ..
  }

[benwells, 2014/05/13 11:41:55]

Done.

     LaunchPlatformAppWithNoData(profile, extension);
     return;
   }