Don't ever create a file in about:blank when launching packaged apps.

apps/launcher.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "apps/launcher.h"
 
 #include "apps/browser/api/app_runtime/app_runtime_api.h"
 #include "apps/browser/file_handler_util.h"
 #include "apps/common/api/app_runtime.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/extensions/api/file_handlers/app_file_handler_util.h"
 #include "chrome/browser/extensions/api/file_system/file_system_api.h"
 #include "chrome/browser/profiles/profile.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/web_contents.h"
+#include "content/public/common/url_constants.h"
 #include "extensions/browser/event_router.h"
 #include "extensions/browser/extension_host.h"
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/lazy_background_task_queue.h"
 #include "extensions/browser/process_manager.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_messages.h"
 #include "extensions/common/manifest_handlers/kiosk_mode_info.h"
 #include "net/base/filename_util.h"
@@ skipping 311 matching lines @@
     in_kiosk_mode = user_manager && user_manager->IsLoggedInAsKioskApp();
 #endif
     if (!in_kiosk_mode) {
       LOG(ERROR) << "App with 'kiosk_only' attribute must be run in "
           << " ChromeOS kiosk mode.";
       NOTREACHED();
       return;
     }
   }
 
-  if (command_line.GetArgs().empty()) {
+#if defined(OS_WIN)
+  base::CommandLine::StringType about_blank_url(

[tapted, 2014/05/13 06:47:04]

if you don't want the #ifdef, you could use

  base::CommandLine::StringType about_blank_url(
      base::FilePath().AppendASCII(content::kAboutBlankURL).value());


.. I think. But the ifdef is fine, since that's a little weird.

+      base::ASCIIToWide(content::kAboutBlankURL));
+#else
+  base::CommandLine::StringType about_blank_url(content::kAboutBlankURL);
+#endif
+  // Browser tests will add about:blank to the command line. This should
+  // never be interpreted as a file to open, as doing so with an app that
+  // has write access will result in a file 'about' being created, which
+  // causes problems on the bots.
+  if (command_line.GetArgs().empty() ||
+      command_line.GetArgs()[0] == about_blank_url) {

[tapted, 2014/05/13 06:47:04]

Seems unfair to disallow any packaged app from opening a file called
'about:blank'.. You could also check that
command_line.HasSwitch(switches::kTestType)

command_line.GetArgs() is also a little heavyweight, and it's used again below -
maybe cache it?

i.e.

  CommandLine::StringVector args = command_line.GetArgs();
  if (args.empty() || (command_line.HasSwitch(switches::kTestType) &&
                       args[0] == about_blank_url)) {
    ..
  }

[benwells, 2014/05/13 11:41:55]

Done.

     LaunchPlatformAppWithNoData(profile, extension);
     return;
   }
 
   base::FilePath file_path(command_line.GetArgs()[0]);
   scoped_refptr<PlatformAppPathLauncher> launcher =
       new PlatformAppPathLauncher(profile, extension, file_path);
   launcher->LaunchWithRelativePath(current_directory);
 }
 
@@ skipping 47 matching lines @@
 void LaunchPlatformAppWithUrl(Profile* profile,
                               const Extension* extension,
                               const std::string& handler_id,
                               const GURL& url,
                               const GURL& referrer_url) {
   AppEventRouter::DispatchOnLaunchedEventWithUrl(
       profile, extension, handler_id, url, referrer_url);
 }
 
 }  // namespace apps