PaymentRequest: Use "NotAllowedError" instead of "QuotaExceededError".

PaymentRequest: Use "NotAllowedError" instead of "QuotaExceededError".

The spec was changed to return NotAllowedError instead of QuotaExceededError
when the limit of calling canMakePayment() is reached[1].

[1] https://github.com/w3c/browser-payment-api/issues/485

BUG=none

Review-Url: https://codereview.chromium.org/2807023002
Cr-Commit-Position: refs/heads/master@{#463778}
Committed: https://chromium.googlesource.com/chromium/src/+/09a0b538b5a1fe1fb7f273b61fbb548a08658285

[zino, 2017-04-09 16:48:52]

Description was changed from

==========
PaymentRequest: Use "NotAllowedError" instead of "QuotaExceededError".

The spec was changed to return NotAllowedError instead of QuotaExceededError
when the limit of calling canMakePayment() is reached[1].

[1] https://github.com/w3c/browser-payment-api/issues/485

BUG=none
==========

to

==========
PaymentRequest: Use "NotAllowedError" instead of "QuotaExceededError".

The spec was changed to return NotAllowedError instead of QuotaExceededError
when the limit of calling canMakePayment() is reached[1].

[1] https://github.com/w3c/browser-payment-api/issues/485

BUG=none
==========

[zino, 2017-04-10 14:57:26]

jinho.bang@samsung.com changed reviewers:
+ rouslan@chromium.org

[zino, 2017-04-10 14:57:35]

PTAL

[please use gerrit instead, 2017-04-10 15:00:47]

Please double-check with blink-api-owners-discuss@chromium.org that this change
does not require an intent to implement and ship.

[please use gerrit instead, 2017-04-10 15:10:19]

https://codereview.chromium.org/2807023002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right):

https://codereview.chromium.org/2807023002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:1058:
DOMException::create(NotAllowedError, "The canMakePayment() was called too
often."));
Do you  think maybe "Not allowed to check whether can make payment" would be a
better message? Note absence of period at the end to match the old message.

[zkoch1, 2017-04-10 16:29:15]

On 2017/04/10 15:00:47, ಠ_ಠ wrote:
> Please double-check with mailto:blink-api-owners-discuss@chromium.org that
this change
> does not require an intent to implement and ship.

I don't think requires an intent to implement and ship. I think we can just make
and submit the change. Developer risk for this change is very, very low.

[please use gerrit instead, 2017-04-10 16:33:40]

Makes sense. Please address my comment and re-send the review to me.

[zino, 2017-04-10 16:54:30]

On 2017/04/10 16:29:15, zkoch1 wrote:
> On 2017/04/10 15:00:47, ಠ_ಠ wrote:
> > Please double-check with mailto:blink-api-owners-discuss@chromium.org that
> this change
> > does not require an intent to implement and ship.
> 
> I don't think requires an intent to implement and ship. I think we can just
make
> and submit the change. Developer risk for this change is very, very low.

I agree with zkoch1@'s opinion. I think the usage will be very low too.
(I have some similar experiences. e.g.
https://codereview.chromium.org/1532463003/)
We generally send an intent when adding a new api(new method or attribute of
interface).

But I also understand rouslan's concern.
For example, some developer could want to retry again if QuotaExceededError.
canMakePayment(...).
    .then(continueToProcess)
    .catch((error) => {
        if (error.name == "QuotaExceededError")
            retryOneTime();
    });

Is the above pattern recommended?

[zino, 2017-04-10 17:01:20]

I didn't see your last comment.
But if you think this change is risky anyway, I'll check it again (e.g. UMA and
intent to deprecate)

Thanks!

https://codereview.chromium.org/2807023002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right):

https://codereview.chromium.org/2807023002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:1058:
DOMException::create(NotAllowedError, "The canMakePayment() was called too
often."));
On 2017/04/10 15:10:19, ಠ_ಠ wrote:
> Do you  think maybe "Not allowed to check whether can make payment" would be a
> better message? Note absence of period at the end to match the old message.

Done.

[please use gerrit instead, 2017-04-10 20:28:13]

lgtm

[zino, 2017-04-11 13:00:49]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2017-04-11 13:01:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 14:22:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 14:22:45]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[zino, 2017-04-11 19:37:29]

The CQ bit was checked by jinho.bang@samsung.com

[zino, 2017-04-11 19:37:30]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2807023002/#ps40001
(title: "PaymentRequest: Use "NotAllowedError" instead of
"QuotaExceededError".")

[commit-bot: I haz the power, 2017-04-11 19:38:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 21:34:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491939449822320,
"parent_rev": "0877ce62e907e9a76083121c29ce4c7d31f2949f", "commit_rev":
"09a0b538b5a1fe1fb7f273b61fbb548a08658285"}

[commit-bot: I haz the power, 2017-04-11 21:35:33]

Description was changed from

==========
PaymentRequest: Use "NotAllowedError" instead of "QuotaExceededError".

The spec was changed to return NotAllowedError instead of QuotaExceededError
when the limit of calling canMakePayment() is reached[1].

[1] https://github.com/w3c/browser-payment-api/issues/485

BUG=none
==========

to

==========
PaymentRequest: Use "NotAllowedError" instead of "QuotaExceededError".

The spec was changed to return NotAllowedError instead of QuotaExceededError
when the limit of calling canMakePayment() is reached[1].

[1] https://github.com/w3c/browser-payment-api/issues/485

BUG=none

Review-Url: https://codereview.chromium.org/2807023002
Cr-Commit-Position: refs/heads/master@{#463778}
Committed:
https://chromium.googlesource.com/chromium/src/+/09a0b538b5a1fe1fb7f273b61fbb...
==========

[commit-bot: I haz the power, 2017-04-11 21:35:34]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/09a0b538b5a1fe1fb7f273b61fbb...