Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2807023002: PaymentRequest: Use "NotAllowedError" instead of "QuotaExceededError". (Closed)

Created:
3 years, 8 months ago by zino
Modified:
3 years, 8 months ago
CC:
chromium-reviews, blink-reviews, gogerald+paymentswatch_chromium.org, haraken, rouslan+payments_chromium.org, mahmadi+paymentswatch_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

PaymentRequest: Use "NotAllowedError" instead of "QuotaExceededError". The spec was changed to return NotAllowedError instead of QuotaExceededError when the limit of calling canMakePayment() is reached[1]. [1] https://github.com/w3c/browser-payment-api/issues/485 BUG=none Review-Url: https://codereview.chromium.org/2807023002 Cr-Commit-Position: refs/heads/master@{#463778} Committed: https://chromium.googlesource.com/chromium/src/+/09a0b538b5a1fe1fb7f273b61fbb548a08658285

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Patch Set 3 : PaymentRequest: Use "NotAllowedError" instead of "QuotaExceededError". #

Messages

Total messages: 20 (8 generated)
zino
PTAL
3 years, 8 months ago (2017-04-10 14:57:35 UTC) #3
please use gerrit instead
Please double-check with blink-api-owners-discuss@chromium.org that this change does not require an intent to implement and ...
3 years, 8 months ago (2017-04-10 15:00:47 UTC) #4
please use gerrit instead
https://codereview.chromium.org/2807023002/diff/1/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right): https://codereview.chromium.org/2807023002/diff/1/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp#newcode1058 third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:1058: DOMException::create(NotAllowedError, "The canMakePayment() was called too often.")); Do you ...
3 years, 8 months ago (2017-04-10 15:10:19 UTC) #5
zkoch1
On 2017/04/10 15:00:47, ಠ_ಠ wrote: > Please double-check with mailto:blink-api-owners-discuss@chromium.org that this change > does ...
3 years, 8 months ago (2017-04-10 16:29:15 UTC) #6
please use gerrit instead
Makes sense. Please address my comment and re-send the review to me.
3 years, 8 months ago (2017-04-10 16:33:40 UTC) #7
zino
On 2017/04/10 16:29:15, zkoch1 wrote: > On 2017/04/10 15:00:47, ಠ_ಠ wrote: > > Please double-check ...
3 years, 8 months ago (2017-04-10 16:54:30 UTC) #8
zino
I didn't see your last comment. But if you think this change is risky anyway, ...
3 years, 8 months ago (2017-04-10 17:01:20 UTC) #9
please use gerrit instead
lgtm
3 years, 8 months ago (2017-04-10 20:28:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807023002/20001
3 years, 8 months ago (2017-04-11 13:01:08 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/269191)
3 years, 8 months ago (2017-04-11 14:22:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807023002/40001
3 years, 8 months ago (2017-04-11 19:38:10 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 21:35:34 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/09a0b538b5a1fe1fb7f273b61fbb...

Powered by Google App Engine
This is Rietveld 408576698