Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2806993002:
DevTools: WebSocketFrameView - Add frames display control toolbar (Closed)
|
Created:
3 years, 8 months ago by muzuiget Modified:
3 years, 7 months ago CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: WebSocketFrameView - Add frames display control toolbar
Add these features:
* clear frames history
* filter frames by text and type(send/receive)
Screenshot: http://imgur.com/a/JfuMM
BUG=682335
Review-Url: https://codereview.chromium.org/2806993002
Cr-Commit-Position: refs/heads/master@{#472753}
Committed: https://chromium.googlesource.com/chromium/src/+/d6566ac516e88e9f1e96ee46b9fb5f97e38becfc
Patch Set 1 #
Total comments: 5
Patch Set 2 : wip #
Total comments: 12
Patch Set 3 : wip #
Total comments: 5
Patch Set 4 : wip #
Total comments: 4
Patch Set 5 : wip #
Total comments: 5
Patch Set 6 : wip #
Total comments: 6
Patch Set 7 : wip #
Messages
Total messages: 45 (18 generated)
Description was changed from ========== DevTools: WebSocketFrameView - Add frames display control toolbar Add these features: * clear frames history * filter frames by text and type(send/receive) BUG=682335 ========== to ========== DevTools: WebSocketFrameView - Add frames display control toolbar Add these features: * clear frames history * filter frames by text and type(send/receive) BUG=682335 ==========
muzuiget@gmail.com changed reviewers: + allada@chromium.org
muzuiget@gmail.com changed reviewers: + chenwilliam@chromium.org, pfeldman@chromium.org - allada@chromium.org
PTAL
chenwilliam@chromium.org changed reviewers: + allada@chromium.org
Thanks for the patch! I see this is the first chromium patch you have sent in and want to say THANKS A TON! As a cautionary note, please don't get discouraged by our review process, it can be long at times and many times goes through many people before getting approved. If you have any questions or comments don't be afraid to ask. I had this on my list of things to do, but have not been able to get around to it yet, so I personally really appreciate the patch. Anyway, the patch looks good so far, I put in some comments on what I'd suggest doing. I decided not to drill down each item because changing to use a UI.FilterBar and changing it to use index offsets will likely change a bunch of other code, so on next patch I'll drill down a bit more (but I don't expect to have any major issues). I'll bring in more people as this patch comes along for approvals. Thanks again for the patch and as stated before, please don't get discouraged by the lengthy review process :-) https://codereview.chromium.org/2806993002/diff/1/AUTHORS File AUTHORS (right): https://codereview.chromium.org/2806993002/diff/1/AUTHORS#newcode831 AUTHORS:831: JianNeng Zhong <muzuiget@gmail.com> We try to keep this file in alphabetical order (although sometimes we fail at this. Can you please adjust your position to be in alphabetical? https://codereview.chromium.org/2806993002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js (right): https://codereview.chromium.org/2806993002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:63: this._filterTextInput = new UI.ToolbarInput(Common.UIString('Filter'), 0, 0, true); Lets use UI.FilterBar instead, it will handle much of the regular expression stuff. Example: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/devtools/front... https://codereview.chromium.org/2806993002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:67: combobox.addOption(combobox.createOption(Common.UIString('All'), '', '')); Lets instead use FilterBar's ability to show UI.NamedBitSetFilterUI, this works like the "All, XHR, Other" stuff in the network panel's filterbar. Example: https://cs.chromium.org/webrtc/src/third_party/WebKit/Source/devtools/front_e... https://codereview.chromium.org/2806993002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:72: var toolbarItems = [this._deleteAllButton, this._filterTextInput, this._filterTypeCombobox]; I am thinking maybe have the delete/clear button as a context menu item? In a followup I'll bring in our UI/UX lead to see what he says. (for now lets leave it as a button just in case) https://codereview.chromium.org/2806993002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js (right): https://codereview.chromium.org/2806993002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js:1055: this._frames = []; We cannot clear frames here this way because SDK.NetworkRequest is shared and if the frames are cleared like this here, it'd clear them in other locations as well (silently too). I will suggest that we remove this part entirely and instead maintain an index offset position of this array in ResourceWebSocketFrameView.js of what frame index we should start displaying.
Thanks for such a detailed comments. It take me some time to rewrite the code and familiar with the review work-flow What'is change * use UI.FilterBar instead. * use display offset index to implement clear history. Please take a look again.
Thanks for such a detailed comments. It take me some time to rewrite the code and familiar with the review work-flow What'is change * use UI.FilterBar instead. * use display offset index to implement clear history. Please take a look again.
Thanks muzuiget! Things are looking really good. I put some comments in about following how we usually do things. When these are done, I'll apply the patch and dive deeper into making sure we are using the UI objects properly, then I'll give it off for final review (to make sure I didn't miss anything). Thanks again, keep up the good work! https://codereview.chromium.org/2806993002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js (right): https://codereview.chromium.org/2806993002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:66: this._textFilterUI.addEventListener(UI.FilterUI.Events.FilterChanged, this._onFilterUIChanged, this); Lets inline "_onFilterUIChanged" ie: this.refresh https://codereview.chromium.org/2806993002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:68: var typeFilterItems = [ Lets move this to near the bottom of the file. Something like: Network.ResourceWebSocketFrameView._filterTypes = [... https://codereview.chromium.org/2806993002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:72: this._typeFilterSetting = Common.settings.createSetting('resourceWebSocketFrameViewTypeFilters', {}); lets make this a local variable since it's not needed outside the constructor. https://codereview.chromium.org/2806993002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:74: this._typeFilterUI.addEventListener(UI.FilterUI.Events.FilterChanged, this._onFilterUIChanged, this); Same here... inline "_onFilterUIChanged" ie: this.refresh https://codereview.chromium.org/2806993002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:76: this._filterBar = new UI.FilterBar('resourceWebSocketFrameView', true); lets rename this just "websocketFrameView". (resources and network should now be fully separated) https://codereview.chromium.org/2806993002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:77: this._filterBar.addFilter(this._textFilterUI); Did you mean to add this twice? https://codereview.chromium.org/2806993002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:90: this._frameEmptyWidget = new UI.EmptyWidget('Select frame to browse its content.'); I know this was not how it was originally, but can you change this line to: this._frameEmptyWidget = new UI.EmptyWidget(Common.UIString('Select frame to browse its content.')); https://codereview.chromium.org/2806993002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:150: var regex = this._textFilterUI.regex(); In this case regex should be the tester used for both when regex is checked and not. In other words this should be all you need: return regex && regex.test(frame.text) && this._typeFilterUI.accept(frame.type); https://codereview.chromium.org/2806993002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:169: _onClearAllWidgetClicked(event) { Lets rename this "_clearFrames" and remove the event argument, so it's easier to reuse. https://codereview.chromium.org/2806993002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:228: for (var i = start; i < frames.length; ++i) { Can we change this to: frames = frames.slice(this._clearFrameOffset).filter(this._frameFilter.bind(this)); frames.forEach(frame => this._dataGrid.insertChild(new Network.ResourceWebSocketFrameNode(url, frame)));
Code update again, please take a look, thanks. https://codereview.chromium.org/2806993002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js (right): https://codereview.chromium.org/2806993002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:77: this._filterBar.addFilter(this._textFilterUI); On 2017/04/17 21:11:19, allada wrote: > Did you mean to add this twice? Sorry, I didn't get your point. One is "_textFilterUI" another is "_typeFilterUI"
Sorry for having to backtrack a little on you, but I applied the patch on my local build and showed it to my TL and he wanted a few UI tweeks. He wants everything to go on one line (like cookies), and he doesn't want us to use the BitSetFilter. But everything looks really good and looking forward to seeing this committed :-) If you have questions don't be afraid to ask. Thanks! https://codereview.chromium.org/2806993002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js (right): https://codereview.chromium.org/2806993002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:77: this._filterBar.addFilter(this._textFilterUI); On 2017/04/20 09:40:01, muzuiget wrote: > On 2017/04/17 21:11:19, allada wrote: > > Did you mean to add this twice? > > Sorry, I didn't get your point. One is "_textFilterUI" another is > "_typeFilterUI" I see. https://codereview.chromium.org/2806993002/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js (right): https://codereview.chromium.org/2806993002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:69: this._typeFilterUI = new UI.NamedBitSetFilterUI(Network.ResourceWebSocketFrameView.filterTypes, typeFilterSetting); Also sorry, here after speaking with my TL he said we want to deprecate UI.NamedBitSetFilterUI, and in this case he wants us to use a select box (dropdown box) instead. https://codereview.chromium.org/2806993002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:72: this._filterBar = new UI.FilterBar('websocketFrameView', true); Sorry if I switched this on you, but I spoke with one of the members of the team and we think it'd be best if the toolbar was all on one line similar to how cookies filter is. (http://imgur.com/a/OBgd8) see this for refs: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/devtools/front... https://codereview.chromium.org/2806993002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:143: * @param {!SDK.NetworkRequest.WebSocketFrame} frame nit: While we are here, can you add: * @return {boolean} https://codereview.chromium.org/2806993002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:147: return (regex ? regex.test(frame.text) : true) && this._typeFilterUI.accept(frame.type); is there a reason we cant use this? return !!regex && regex.test(frame.text) && this._typeFilterUI.accept(frame.type); https://codereview.chromium.org/2806993002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:234: Network.ResourceWebSocketFrameView.filterTypes = [ nit (doctype and it's private): /** @type {!Array<!UI.NamedBitSetFilterUI.Item>} */ Network.ResourceWebSocketFrameView._filterTypes
On 2017/04/24 18:28:14, allada wrote: > Sorry for having to backtrack a little on you, but I applied the patch on my > local build and showed it to my TL and he wanted a few UI tweeks. > > He wants everything to go on one line (like cookies), and he doesn't want us to > use the BitSetFilter. > > But everything looks really good and looking forward to seeing this committed > :-) > > If you have questions don't be afraid to ask. > Thanks! > Never mind, just a weekend coding to learn devtools programing. ;-) > https://codereview.chromium.org/2806993002/diff/20001/third_party/WebKit/Sour... > File > third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js > (right): > > https://codereview.chromium.org/2806993002/diff/20001/third_party/WebKit/Sour... > third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:77: > this._filterBar.addFilter(this._textFilterUI); > On 2017/04/20 09:40:01, muzuiget wrote: > > On 2017/04/17 21:11:19, allada wrote: > > > Did you mean to add this twice? > > > > Sorry, I didn't get your point. One is "_textFilterUI" another is > > "_typeFilterUI" > > I see. > > https://codereview.chromium.org/2806993002/diff/40001/third_party/WebKit/Sour... > File > third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js > (right): > > https://codereview.chromium.org/2806993002/diff/40001/third_party/WebKit/Sour... > third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:69: > this._typeFilterUI = new > UI.NamedBitSetFilterUI(Network.ResourceWebSocketFrameView.filterTypes, > typeFilterSetting); > Also sorry, here after speaking with my TL he said we want to deprecate > UI.NamedBitSetFilterUI, and in this case he wants us to use a select box > (dropdown box) instead. > > https://codereview.chromium.org/2806993002/diff/40001/third_party/WebKit/Sour... > third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:72: > this._filterBar = new UI.FilterBar('websocketFrameView', true); > Sorry if I switched this on you, but I spoke with one of the members of the team > and we think it'd be best if the toolbar was all on one line similar to how > cookies filter is. (http://imgur.com/a/OBgd8) > > see this for refs: > https://cs.chromium.org/chromium/src/third_party/WebKit/Source/devtools/front... > So, do I keep using FilterBar or plain Toolbar? Filter input in Cookie editor doesn't has regexp support.
On 2017/04/26 09:18:50, muzuiget wrote: > So, do I keep using FilterBar or plain Toolbar? Filter input in Cookie editor > doesn't has regexp support. I think just Toolbar since I believe FilterBar manages the hiding the filter bar. I'll defer to +dgozman for his opinion.
allada@chromium.org changed reviewers: + dgozman@chromium.org
On 2017/04/27 21:10:23, allada wrote: > On 2017/04/26 09:18:50, muzuiget wrote: > > So, do I keep using FilterBar or plain Toolbar? Filter input in Cookie editor > > doesn't has regexp support. > > I think just Toolbar since I believe FilterBar manages the hiding the filter > bar. > > I'll defer to +dgozman for his opinion. Yeah, go with Toolbar in this case.
Code updated, use plain Toolbar and Combobox. PTAL.
Just a few things I suggest. I'm pretty much good, I'll stamp it after next patchset changes. I think it's ready for dgozman@ to have a look as well. https://codereview.chromium.org/2806993002/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js (right): https://codereview.chromium.org/2806993002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:69: Network.ResourceWebSocketFrameView._filterTypes.forEach(v => { nit: rename "v" to "filterItem" https://codereview.chromium.org/2806993002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:76: for (var item of toolbarItems) nit: lets do these as separate lines (since it's the same number of lines and more clear on what it's doing)... I think it might even be better to move "this._mainToolbar = ..." further up and move these lines after the setup of each item retrospectively. this._mainToolbar.appendToolbarItem(this._clearAllButton); ... this._mainToolbar.appendToolbarItem(this._filterTypeCombobox); ... this._mainToolbar.appendToolbarItem(this._filterTextInput); https://codereview.chromium.org/2806993002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:147: return (!regex || regex.test(frame.text)) && (!type || frame.type === type); nit: lets reverse the logic on this, since type checking is much cheaper than regex checking we can hopefully save the need to do some of the regex code. eg (you can try and squeeze it into one line if you want)... if (this._filterType && frame.type !== this._filterType) return false; return !this._filterRegex || this._filterRegex.test(frame.text); https://codereview.chromium.org/2806993002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:242: Network.ResourceWebSocketFrameView._filterTypes = [ nit: Please add this above this line: /** @type {!Array<!UI.NamedBitSetFilterUI.Item>} */
Code updated, PTAL.
Looks pretty good! https://codereview.chromium.org/2806993002/diff/80001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js (right): https://codereview.chromium.org/2806993002/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:26: constructor(request) { When I switch to another request, and then back to this WebSocket, the "cleared" state will be lost. Let's either put it on request using symbol or actually remove frames from request. https://codereview.chromium.org/2806993002/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:69: Network.ResourceWebSocketFrameView._filterTypes.forEach(filterItem => { nit: for (var filterItem of Network.ResourceWebSocketFrameView._filterTypes) { .... } https://codereview.chromium.org/2806993002/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:75: this._filterTextInput = new UI.ToolbarInput(Common.UIString('Filter'), 0.4, undefined, true); Let's have a placeholder mentioning it's a regex. https://codereview.chromium.org/2806993002/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:151: this._clearFrameOffset = this._request.frames().length; // TODO(allada): actually remove frames from request instance.
lgtm % dgozman@'s changes. Good Job :-)
Code updated. > Let's either put it on request using symbol or actually remove frames from request I am not sure the "symbol" mean, it mean "flag variable" or "JavaScript Symbol type object"? I treat it as the former, move the "_clearFrameOffet" variable to request object, maybe quick-and-dirty.
https://codereview.chromium.org/2806993002/diff/80001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js (right): https://codereview.chromium.org/2806993002/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:151: this._clearFrameOffset = this._request.frames().length; On 2017/05/04 17:55:32, dgozman wrote: > // TODO(allada): actually remove frames from request instance. What about this one? https://codereview.chromium.org/2806993002/diff/100001/third_party/WebKit/Sou... File third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js (right): https://codereview.chromium.org/2806993002/diff/100001/third_party/WebKit/Sou... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:75: this._filterTextInput = new UI.ToolbarInput(Common.UIString('Filter'), 0.4, undefined, true); So, what about placeholder saying "Enter regex, for example: (web)?socket" https://codereview.chromium.org/2806993002/diff/100001/third_party/WebKit/Sou... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:152: this._request._clearFrameOffset = this._request.frames().length; I meant JavaScript symbol here: this._request[Network.ResourceWebSocketFrameView._clearOffsetSymbol] = ... Somewhere at the end: Network.ResourceWebSocketFrameView._clearOffsetSymbol = Symbol('clearOffset');
https://codereview.chromium.org/2806993002/diff/100001/third_party/WebKit/Sou... File third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js (right): https://codereview.chromium.org/2806993002/diff/100001/third_party/WebKit/Sou... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:152: this._request._clearFrameOffset = this._request.frames().length; Please add this above this line: // TODO(allada): actially remove frames from request. https://codereview.chromium.org/2806993002/diff/100001/third_party/WebKit/Sou... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:152: this._request._clearFrameOffset = this._request.frames().length; Example of the symbol stuff he was talking about: this._request[Network.ResourceWebSocketFrameView._clearFrameOffsetSymbol] = this._request.frames().length; https://codereview.chromium.org/2806993002/diff/100001/third_party/WebKit/Sou... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:210: frames = frames.slice(this._request._clearFrameOffset || 0); And here would be: var offset = this._request[Network.ResourceWebSocketFrameView._clearFrameOffsetSymbol] || 0; frames = frames.slice(offset); https://codereview.chromium.org/2806993002/diff/100001/third_party/WebKit/Sou... third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:219: Then add this here: Network.ResourceWebSocketFrameView._clearFrameOffsetSymbol = Symbol('ClearFrameOffset');
Sorry for the late resonse, code updated.
lgtm. Thank you for contributing!
Everything is done and you are able to check the "commit" button and it'll begin the build bot process. Can you please however add a very basic screenshot of the UI changes that were made. (example: https://codereview.chromium.org/2867713006/ [note the description]) Thanks again for the contribution!
Description was changed from ========== DevTools: WebSocketFrameView - Add frames display control toolbar Add these features: * clear frames history * filter frames by text and type(send/receive) BUG=682335 ========== to ========== DevTools: WebSocketFrameView - Add frames display control toolbar Add these features: * clear frames history * filter frames by text and type(send/receive) Screenshot: http://imgur.com/a/JfuMM BUG=682335 ==========
The CQ bit was checked by muzuiget@gmail.com
The patchset sent to the CQ was uploaded after l-g-t-m from allada@chromium.org Link to the patchset: https://codereview.chromium.org/2806993002/#ps120001 (title: "wip")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
The author muzuiget@gmail.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign and manage CLA.
The CQ bit was checked by muzuiget@gmail.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by muzuiget@gmail.com
The CQ bit was checked by muzuiget@gmail.com
The CQ bit was unchecked by muzuiget@gmail.com
The CQ bit was checked by muzuiget@gmail.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by muzuiget@gmail.com
The CQ bit was checked by muzuiget@gmail.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1495083595369360,
"parent_rev": "e82ba08821352cde479db52f3b9379ea23d2b54b", "commit_rev":
"d6566ac516e88e9f1e96ee46b9fb5f97e38becfc"}
Message was sent while issue was closed.
Description was changed from ========== DevTools: WebSocketFrameView - Add frames display control toolbar Add these features: * clear frames history * filter frames by text and type(send/receive) Screenshot: http://imgur.com/a/JfuMM BUG=682335 ========== to ========== DevTools: WebSocketFrameView - Add frames display control toolbar Add these features: * clear frames history * filter frames by text and type(send/receive) Screenshot: http://imgur.com/a/JfuMM BUG=682335 Review-Url: https://codereview.chromium.org/2806993002 Cr-Commit-Position: refs/heads/master@{#472753} Committed: https://chromium.googlesource.com/chromium/src/+/d6566ac516e88e9f1e96ee46b9fb... ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as https://chromium.googlesource.com/chromium/src/+/d6566ac516e88e9f1e96ee46b9fb... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
