Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2806983002: ChromeOS OOBE: Update Welcome dialog to better accomodate CfM messages. (Closed)

Created:
3 years, 8 months ago by Alexander Alekseev
Modified:
3 years, 8 months ago
Reviewers:
jdufault
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS OOBE: Update Welcome dialog to better accomodate CfM messages. CfM uses longer elcoming text so this Cl makes the presentation better. BUG=704059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2806983002 Cr-Commit-Position: refs/heads/master@{#463573} Committed: https://chromium.googlesource.com/chromium/src/+/48d63103e76cc388b4fe5151b2cb66d8af56bbaf

Patch Set 1 #

Patch Set 2 : Set header side marging to 80px. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_welcome_dialog.css View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Alexander Alekseev
Please review.
3 years, 8 months ago (2017-04-08 05:55:38 UTC) #3
jdufault
On 2017/04/08 05:55:38, Alexander Alekseev wrote: > Please review. Based on the bug it looks ...
3 years, 8 months ago (2017-04-10 19:22:54 UTC) #8
jdufault
lgtm after in-person discussion; let's push to change welcome text to just "Welcome" to avoid ...
3 years, 8 months ago (2017-04-10 21:32:15 UTC) #9
Alexander Alekseev
3 years, 8 months ago (2017-04-11 06:49:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806983002/20001
3 years, 8 months ago (2017-04-11 06:49:40 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 08:17:40 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/48d63103e76cc388b4fe5151b2cb...

Powered by Google App Engine
This is Rietveld 408576698