Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 2806963002: Implement BrowserAccessibility accNavigate() in terms of AXPlatformNodeWin. (Closed)

Created:
3 years, 8 months ago by dougt
Modified:
3 years, 8 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement BrowserAccessibility accNavigate() in terms of AXPlatformNodeWin. Here we are implementing one more IAccessibility method, accNavigate(), in terms of ui::AXPlatformNodeWin. The idea is that we can forward IAccessibility calls to ui::AXPlatformNodeWin and then slowly trim down, and maybe remove, BrowserAccessibilityWin. Note that this does not forward NAVDIR_. That will be a follow up. BUG=703369 patch from issue 2789333002 at patchset 40001 (http://crrev.com/2789333002#ps40001) Review-Url: https://codereview.chromium.org/2806963002 Cr-Commit-Position: refs/heads/master@{#463273} Committed: https://chromium.googlesource.com/chromium/src/+/8c756e00873d3dfe7c07609a3b4f21885a552b1f

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -19 lines) Patch
M content/browser/accessibility/browser_accessibility_win.cc View 2 chunks +4 lines, -19 lines 1 comment Download
M ui/accessibility/platform/ax_platform_node_win.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
dougt
PTAL
3 years, 8 months ago (2017-04-08 04:43:03 UTC) #5
dougt
https://codereview.chromium.org/2806963002/diff/1/content/browser/accessibility/browser_accessibility_win.cc File content/browser/accessibility/browser_accessibility_win.cc (right): https://codereview.chromium.org/2806963002/diff/1/content/browser/accessibility/browser_accessibility_win.cc#newcode494 content/browser/accessibility/browser_accessibility_win.cc:494: BrowserAccessibilityWin* target = GetTargetFromChildID(start); I mentioned this elsewhere, I ...
3 years, 8 months ago (2017-04-08 06:49:30 UTC) #8
dmazzoni
lgtm
3 years, 8 months ago (2017-04-10 07:21:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806963002/1
3 years, 8 months ago (2017-04-10 14:25:40 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 15:40:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8c756e00873d3dfe7c07609a3b4f...

Powered by Google App Engine
This is Rietveld 408576698