Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1202)

Issue 2806883002: Add QUIC_STREAM_FACTORY_JOB specific logs to track the Job's state machine. (Closed)

Created:
3 years, 8 months ago by Zhongyi Shi
Modified:
3 years, 8 months ago
Reviewers:
eroman, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, eroman, mmenke, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add QUIC_STREAM_FACTORY_JOB specific logs to track the Job's state machine. BUG=702411 Review-Url: https://codereview.chromium.org/2806883002 Cr-Commit-Position: refs/heads/master@{#463099} Committed: https://chromium.googlesource.com/chromium/src/+/fc46696ff2d37c43d4604cc2e996c8f2e3d2dcf0

Patch Set 1 #

Total comments: 2

Patch Set 2 : addess #3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M net/log/net_log_event_type_list.h View 1 1 chunk +11 lines, -0 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.cc View 4 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Zhongyi Shi
3 years, 8 months ago (2017-04-07 22:47:00 UTC) #2
Ryan Hamilton
lgtm https://codereview.chromium.org/2806883002/diff/1/net/log/net_log_event_type_list.h File net/log/net_log_event_type_list.h (right): https://codereview.chromium.org/2806883002/diff/1/net/log/net_log_event_type_list.h#newcode1664 net/log/net_log_event_type_list.h:1664: EVENT_TYPE(QUIC_STREAM_FACTORY_JOB_LOAD_SERVER_INFO) Please comment.
3 years, 8 months ago (2017-04-07 22:53:19 UTC) #3
Zhongyi Shi
eroman@: ptal, thanks! https://codereview.chromium.org/2806883002/diff/1/net/log/net_log_event_type_list.h File net/log/net_log_event_type_list.h (right): https://codereview.chromium.org/2806883002/diff/1/net/log/net_log_event_type_list.h#newcode1664 net/log/net_log_event_type_list.h:1664: EVENT_TYPE(QUIC_STREAM_FACTORY_JOB_LOAD_SERVER_INFO) On 2017/04/07 22:53:19, Ryan Hamilton ...
3 years, 8 months ago (2017-04-07 23:05:59 UTC) #4
eroman
lgtm
3 years, 8 months ago (2017-04-07 23:45:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806883002/20001
3 years, 8 months ago (2017-04-07 23:47:02 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-08 01:34:50 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fc46696ff2d37c43d4604cc2e996...

Powered by Google App Engine
This is Rietveld 408576698