Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2806873002:
Fix UMA metric "WinJumplist.DirectoryStatusJumpListIconsOld" (Closed)
DescriptionFix UMA metric "WinJumplist.DirectoryStatusJumpListIconsOld"
The base::IsDirectoryEmpty() method returns true when the directory
doesn't exist or the directory is empty. We need to use
base::DirectoryExists() together with base::IsDirectoryEmpty() to
differentiate these two situations.
BUG=40407, 179576
Review-Url: https://codereview.chromium.org/2806873002
Cr-Commit-Position: refs/heads/master@{#463297}
Committed: https://chromium.googlesource.com/chromium/src/+/f1f0e8de131c57105cff16a07d8b9772e0ba13f6
Patch Set 1 #
Messages
Total messages: 16 (12 generated)
The CQ bit was checked by chengx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix UMA metric "WinJumplist.DirectoryStatusJumpListIconsOld" BUG=40407, 179576 ========== to ========== Fix UMA metric "WinJumplist.DirectoryStatusJumpListIconsOld" The method base::IsDirectoryEmpty() returns true when the directory doesn't exist or the directory is empty. Therefore, we need to separate these two situations using base::DirectoryExists() together with base::IsDirectoryEmpty(). BUG=40407, 179576 ==========
Description was changed from ========== Fix UMA metric "WinJumplist.DirectoryStatusJumpListIconsOld" The method base::IsDirectoryEmpty() returns true when the directory doesn't exist or the directory is empty. Therefore, we need to separate these two situations using base::DirectoryExists() together with base::IsDirectoryEmpty(). BUG=40407, 179576 ========== to ========== Fix UMA metric "WinJumplist.DirectoryStatusJumpListIconsOld" The method base::IsDirectoryEmpty() returns true when the directory doesn't exist or the directory is empty. We need to use base::DirectoryExists() together with base::IsDirectoryEmpty() to differentiate these two situations. BUG=40407, 179576 ==========
Description was changed from ========== Fix UMA metric "WinJumplist.DirectoryStatusJumpListIconsOld" The method base::IsDirectoryEmpty() returns true when the directory doesn't exist or the directory is empty. We need to use base::DirectoryExists() together with base::IsDirectoryEmpty() to differentiate these two situations. BUG=40407, 179576 ========== to ========== Fix UMA metric "WinJumplist.DirectoryStatusJumpListIconsOld" The method base::IsDirectoryEmpty() returns true when the directory doesn't exist or the directory is empty. We need to use base::DirectoryExists() together with base::IsDirectoryEmpty() to differentiate these two situations. BUG=40407, 179576 ==========
Description was changed from ========== Fix UMA metric "WinJumplist.DirectoryStatusJumpListIconsOld" The method base::IsDirectoryEmpty() returns true when the directory doesn't exist or the directory is empty. We need to use base::DirectoryExists() together with base::IsDirectoryEmpty() to differentiate these two situations. BUG=40407, 179576 ========== to ========== Fix UMA metric "WinJumplist.DirectoryStatusJumpListIconsOld" The base::IsDirectoryEmpty() method returns true when the directory doesn't exist or the directory is empty. We need to use base::DirectoryExists() together with base::IsDirectoryEmpty() to differentiate these two situations. BUG=40407, 179576 ==========
chengx@chromium.org changed reviewers: + gab@chromium.org
Another post small fix. This is motivated by the confusing UMA data from the previous few days. PTAL~
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by gab@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1491841051016110, "parent_rev":
"a9199c53b3525282ba88265be606efe81c2c8477", "commit_rev":
"f1f0e8de131c57105cff16a07d8b9772e0ba13f6"}
Message was sent while issue was closed.
Description was changed from ========== Fix UMA metric "WinJumplist.DirectoryStatusJumpListIconsOld" The base::IsDirectoryEmpty() method returns true when the directory doesn't exist or the directory is empty. We need to use base::DirectoryExists() together with base::IsDirectoryEmpty() to differentiate these two situations. BUG=40407, 179576 ========== to ========== Fix UMA metric "WinJumplist.DirectoryStatusJumpListIconsOld" The base::IsDirectoryEmpty() method returns true when the directory doesn't exist or the directory is empty. We need to use base::DirectoryExists() together with base::IsDirectoryEmpty() to differentiate these two situations. BUG=40407, 179576 Review-Url: https://codereview.chromium.org/2806873002 Cr-Commit-Position: refs/heads/master@{#463297} Committed: https://chromium.googlesource.com/chromium/src/+/f1f0e8de131c57105cff16a07d8b... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f1f0e8de131c57105cff16a07d8b... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
